Skip to content

[hotfix] Short circuit judgment for create blob storage dir #26338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[hotfix] Short circuit judgment for create blob storage dir #26338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ static Reference<File> createBlobStorageDirectory(
if (fallbackStorageDirectory != null) {
baseDir = fallbackStorageDirectory.deref();

if (baseDir.mkdirs() || baseDir.exists()) {
if (baseDir.exists() || baseDir.mkdirs()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first thing that mkdirs() does is call exists(). Can we remove the baseDir.exists()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reminder. But it let me take a second thinking.
After the second thinking, it's no need to change this line.

return fallbackStorageDirectory;
}
}
Expand Down