[FLINK-7908][FLINK-7824][QS] Restructure QS packages and put QS jars in opt/. #4906
Conversation
There was a problem hiding this comment.
Very good changes? I had some nitpicks in the code and some more here. 😅
Does the client jar have to be in opt?
I think queryable-state-core should be called queryable-state-runtime or queryable-state-server to fit into existing Flink Terminology. For example, flink-core is this quite thin module that has mostly API classes and some stuff that is commonly used. What do you think?
| * | ||
| * <p><b>THIS WAS COPIED FROM RUNTIME SO THAT WE AVOID THE DEPENDENCY.</b> | ||
| */ | ||
| public final class VoidNamespace { |
There was a problem hiding this comment.
Can these be package private?
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| /** | ||
| * Javadoc. |
|
Btw, I'm assuming you also tried this with a cluster where you put the "core" jar in lib and then could query the state of a running job? |
kl0u
force-pushed
the
qs-restructure
branch
4 times, most recently
from
633ad8f to
f25ada7
Compare
|
LGTM with the name changes! Excellent work. 👍 |
|
Thanks a lot for the review @aljoscha ! Waiting for travis and then merging. |
kl0u
force-pushed
the
qs-restructure
branch
3 times, most recently
from
b601359 to
9bfe6fd
Compare
The QS module is split into core and client. The core should be put in the lib folder to enable queryable state, while the client is the one that the user will program against. The reason for the restructuring in mainly to remove the dependency on the flink-runtime from the user's program.
Now the user can find the jars in the opt/ folder and he can activate QS by putting the core jar in the lib/ folder and program against the client jar.
|
Sorry for joining the party late, but I don't think that it is a good idea to duplicate code by copying code from one module into the other, as happened for the |
What is the purpose of the change
Make the Queryable State more usable by:
clientjar (used by the user) transitively brings.opt/folder. From there, to activate QS the user has to put the core jar in the lib/ folder before starting the cluster, and use the client jar as a dependency to his/her program.Brief change log
Creating the
coreandclientmodules in the queryable state dir and moving classes around.In addition, now the
clientmodule becomes a dependency of theflink-runtime.Places the jars corresponding the aforementioned modules to the
optdir.Verifying this change
This change is a simple restructuring of the queryable state module, no classes are introduced or deleted.
Does this pull request potentially affect one of the following parts:
flink-queryable-state-clientdependency toflink-runtime.Documentation
R @aljoscha