[FLINK-7950][build] add flink-queryable-state-runtime as a dependency to flink-dist #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to flink-dist Since FLINK-7824, flink-queryable-state-runtime's jar file was put into the opt/ folder of flink-dist and is thus required to build as well.
kl0u
approved these changes
Oct 31, 2017
There was a problem hiding this comment.
Thanks for pointing this out @NicoK . The queryable-state dependency should move to the optional libraries section though (after the comment <!-- start optional Flink libraries --> in the dist pom). After that, this PR is good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Since #4906,
flink-queryable-state-runtime's jar file was put into theopt/folder of
flink-distand is thus required to build as well.Brief change log
flink-queryable-state-runtimeas a (provided) dependency toflink-distVerifying this change
This change can be verified by building the
flink-distsub-project:mvn install -pl flink-dist -amand verifying that it builds as well as thatorg.apache.flink.queryablestate.client.proxy.KvStateClientProxyHandleris not part of theflink-distuber jar.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation