HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (closeCommand.getForce()) { | ||
| // SCM told us to force close the container. | ||
| controller.closeContainer(containerId); | ||
| } |
There was a problem hiding this comment.
Not exactly related to this patch, but this part of code has become a little bit messy.
We should be able to refactor this.
switch (container.getContainerState()) {
case OPEN:
controller.markContainerForClose(containerId);
case CLOSING:
final HddsProtos.PipelineID pipelineID = closeCommand.getPipelineID();
final XceiverServerSpi writeChannel = ozoneContainer.getWriteChannel();
if (writeChannel.isExist(pipelineID)) {
writeChannel.submitRequest(getContainerCommandRequestProto(
datanodeDetails, containerId), pipelineID);
} else {
controller.markContainerUnhealthy(containerId);
}
break;
case QUASI_CLOSED:
if (closeCommand.getForce()) {
controller.closeContainer(containerId);
break;
}
case CLOSED:
case UNHEALTHY:
case INVALID:
LOG.debug("Cannot close the container #{}, the container is" +
" in {} state.", containerId, container.getContainerState());
}
There was a problem hiding this comment.
addressed in 2nd comit
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If markContainerForClose fails, quasiCloseContainer will definitely fail. We can put both of the calls into same try catch.
There was a problem hiding this comment.
addressed in 2nd comit
|
💔 -1 overall
This message was automatically generated. |
|
@nandakumar131 Thanks for reviewing the PR! 2nd commit addresses checkstyle issues and review comments. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Test failures are not related. |
nandakumar131
approved these changes
Sep 6, 2019
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a pipeline is destroyed by SCM, all the container on the pipeline are marked as quasi closed when datanode received close container command. SCM while processing these containers reports, marks these containers as closed once majority of the nodes are available.
This is however not a sufficient condition in cases where the raft log directory is missing or corrupted. As the containers will not have all the applied transaction.
To solve this problem, we should QUASI_CLOSE the containers in datanode as part of ratis groupRemove. If a container is in OPEN state in datanode without any active pipeline, it will be marked as Unhealthy while processing close container command.