HBASE-24875 Remove the force param for unassign since it dose not take effect any more #2254

bsglz · 2020-08-13T08:20:35Z

No description provided.

wchevreuil

Bit confused by the original description here, it suggests this was only a doc change, but there are new methods definitions and deprecations in the API.

Can you explain better the motivation behind this change?

bsglz · 2020-08-13T11:13:51Z

Bit confused by the original description here, it suggests this was only a doc change, but there are new methods definitions and deprecations in the API.

Can you explain better the motivation behind this change?

Yeah, it indeed confusion, updated yet.
Thanks.

…e effect any more

virajjasani · 2020-08-13T11:44:31Z

Is this driven by https://issues.apache.org/jira/browse/HBASE-20881 ?

bsglz · 2020-08-13T12:19:21Z

Is this driven by https://issues.apache.org/jira/browse/HBASE-20881 ?

Seems earlier, by https://issues.apache.org/jira/browse/HBASE-14614(AMv2), though the UnassignProcedure.java has force variate, but does not take effect.

virajjasani · 2020-08-13T13:41:56Z

Is this driven by https://issues.apache.org/jira/browse/HBASE-20881 ?

Seems earlier, by https://issues.apache.org/jira/browse/HBASE-14614(AMv2), though the UnassignProcedure.java has force variate, but does not take effect.

Okk sounds good, in this case, you can also evaluate removing force from UnassignProcedure class with this PR :)

bsglz · 2020-08-13T15:35:04Z

No prob. @virajjasani

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java

hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java

busbey · 2020-08-14T04:07:12Z

hbase-shell/src/main/ruby/hbase/admin.rb

@@ -537,8 +537,8 @@ def assign(region_name)

    #----------------------------------------------------------------------------------------------
    # Unassign a region
-    def unassign(region_name, force)
-      @admin.unassign(region_name.to_java_bytes, java.lang.Boolean.valueOf(force))
+    def unassign(region_name)


this breaks compatibility for the shell and will need to be release noted. Alternatively you could do the analagous thing as in the Admin apis and deprecate the second parameter by making it optional and stating it is ignored.

Will fix later. Thanks.

this compatibility break is still present. could you correct it similar to how you did for the unassign shell command?

Fixed, Thanks.

hbase-shell/src/main/ruby/shell/commands/unassign.rb

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java

Apache-HBase · 2020-08-14T05:24:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 6s	master passed
+1 💚	compile	2m 30s	master passed
+1 💚	shadedjars	5m 45s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
-0 ⚠️	javadoc	0m 51s	hbase-thrift in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	2m 30s	the patch passed
+1 💚	javac	2m 30s	the patch passed
+1 💚	shadedjars	5m 41s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 24s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 50s	hbase-thrift in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	132m 34s	hbase-server in the patch passed.
+1 💚	unit	4m 25s	hbase-thrift in the patch passed.
+1 💚	unit	7m 23s	hbase-shell in the patch passed.
		178m 14s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9b69beb999c3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c81ef73`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/testReport/
Max. process+thread count	3760 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-14T06:46:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	2m 10s	master passed
+1 💚	shadedjars	6m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	shadedjars	6m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 6s	hbase-client in the patch passed.
+1 💚	unit	212m 29s	hbase-server in the patch passed.
+1 💚	unit	5m 40s	hbase-thrift in the patch passed.
+1 💚	unit	8m 34s	hbase-shell in the patch passed.
		260m 40s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e5ea6ed732f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c81ef73`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/testReport/
Max. process+thread count	3382 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-14T08:34:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	checkstyle	2m 41s	master passed
+1 💚	spotbugs	7m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	checkstyle	0m 11s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 29s	hbase-client: The patch generated 0 new + 106 unchanged - 1 fixed = 106 total (was 107)
+1 💚	checkstyle	1m 6s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 41s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 12s	The patch passed checkstyle in hbase-shell
-0 ⚠️	rubocop	0m 9s	The patch generated 3 new + 341 unchanged - 0 fixed = 344 total (was 341)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 20s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 51s	the patch passed
+1 💚	spotbugs	8m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 2s	The patch does not generate ASF License warnings.
		52m 41s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux a63d0183ff15 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c81ef73`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-14T11:32:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	3m 28s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
-0 ⚠️	javadoc	0m 52s	hbase-thrift in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	3m 30s	the patch passed
+1 💚	javac	3m 30s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 50s	hbase-thrift in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 0s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 6s	hbase-client in the patch passed.
+1 💚	unit	128m 37s	hbase-server in the patch passed.
+1 💚	unit	3m 54s	hbase-thrift in the patch passed.
+1 💚	unit	7m 11s	hbase-shell in the patch passed.
		177m 29s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2797860a13e0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c81ef73`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/testReport/
Max. process+thread count	4750 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-14T11:42:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 14s	master passed
+1 💚	compile	3m 16s	master passed
+1 💚	shadedjars	6m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	3m 24s	the patch passed
+1 💚	javac	3m 24s	the patch passed
+1 💚	shadedjars	6m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 51s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 15s	hbase-client in the patch passed.
+1 💚	unit	151m 47s	hbase-server in the patch passed.
+1 💚	unit	4m 33s	hbase-thrift in the patch passed.
+1 💚	unit	7m 14s	hbase-shell in the patch passed.
		202m 41s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fcb236e1644a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c81ef73`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/testReport/
Max. process+thread count	4337 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bsglz · 2020-08-20T02:47:37Z

Ping. @busbey

busbey

updated the thread on the hbase shell Admin class having a compatibility issue.

bsglz · 2020-08-28T03:02:57Z

updated the thread on the hbase shell Admin class having a compatibility issue.

Fixed, thanks. @busbey

Apache-HBase · 2020-08-28T04:08:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 56s	master passed
+1 💚	checkstyle	2m 46s	master passed
+1 💚	spotbugs	8m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	checkstyle	0m 11s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 29s	hbase-client: The patch generated 0 new + 106 unchanged - 1 fixed = 106 total (was 107)
+1 💚	checkstyle	1m 8s	The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 41s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-shell
-0 ⚠️	rubocop	0m 11s	The patch generated 2 new + 352 unchanged - 0 fixed = 354 total (was 352)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	3m 39s	the patch passed
+1 💚	spotbugs	12m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 14s	The patch does not generate ASF License warnings.
		66m 15s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 4c7f86748a60 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047e061`
rubocop	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-28T06:34:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	3m 39s	master passed
+1 💚	shadedjars	7m 18s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 31s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 52s	hbase-server in master failed.
-0 ⚠️	javadoc	1m 8s	hbase-thrift in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 37s	the patch passed
+1 💚	compile	4m 19s	the patch passed
+1 💚	javac	4m 19s	the patch passed
+1 💚	shadedjars	9m 15s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 32s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 50s	hbase-server in the patch failed.
-0 ⚠️	javadoc	1m 11s	hbase-thrift in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 16s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 24s	hbase-client in the patch passed.
+1 💚	unit	152m 30s	hbase-server in the patch passed.
+1 💚	unit	4m 16s	hbase-thrift in the patch passed.
+1 💚	unit	8m 9s	hbase-shell in the patch passed.
		212m 7s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fcdc10c84075 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047e061`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/testReport/
Max. process+thread count	4274 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-28T07:44:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	3m 40s	master passed
+1 💚	shadedjars	7m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	compile	3m 59s	the patch passed
+1 💚	javac	3m 59s	the patch passed
+1 💚	shadedjars	8m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 53s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	222m 45s	hbase-server in the patch passed.
+1 💚	unit	5m 21s	hbase-thrift in the patch passed.
+1 💚	unit	8m 42s	hbase-shell in the patch passed.
		282m 22s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2254
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b14328415eb0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047e061`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/testReport/
Max. process+thread count	3907 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2254/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bsglz · 2020-09-07T05:37:35Z

Ping. @busbey

busbey

looks good. thanks for working through things!

bsglz · 2020-09-16T05:36:24Z

Thanks a lot.

…e effect any more (#2254) Modified compared to main branch to deprecate obviated MasterObserver interface methods instead of remove them. Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit c5ca191) Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdmin.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java

…e effect any more (apache#2254) Modified compared to main branch to deprecate obviated MasterObserver interface methods instead of remove them. Signed-off-by: Sean Busbey <busbey@apache.org> (cherry picked from commit c5ca191) Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdmin.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java

This comment has been minimized.

Sign in to view

wchevreuil reviewed Aug 13, 2020

View reviewed changes

HBASE-24875 Remove the force param for unassign since it dose not tak…

8fe4e72

…e effect any more

bsglz force-pushed the HBASE-24875 branch from c3bfd16 to 8fe4e72 Compare August 13, 2020 11:19

bsglz changed the title ~~HBASE-24875 The describe and param for unassign not correct since the…~~ HBASE-24875 Remove the force param for unassign since it dose not take effect any more Aug 13, 2020

bsglz requested a review from wchevreuil August 13, 2020 11:20

This comment has been minimized.

Sign in to view

remove force var from UnassignProcedure

dc9832e

This comment has been minimized.

Sign in to view

fix checkstyle warnings

e388b36

This comment has been minimized.

Sign in to view

busbey requested changes Aug 14, 2020

View reviewed changes

fix review issue

e34b3b2

bsglz requested a review from busbey August 14, 2020 07:07

busbey requested changes Aug 27, 2020

View reviewed changes

fix review issue

4564dc3

bsglz requested a review from busbey August 31, 2020 05:43

busbey approved these changes Sep 16, 2020

View reviewed changes

busbey merged commit c5ca191 into apache:master Sep 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24875 Remove the force param for unassign since it dose not take effect any more #2254

HBASE-24875 Remove the force param for unassign since it dose not take effect any more #2254

bsglz commented Aug 13, 2020 •

edited

Loading

This comment has been minimized.

wchevreuil left a comment

bsglz commented Aug 13, 2020

This comment has been minimized.

virajjasani commented Aug 13, 2020

bsglz commented Aug 13, 2020

This comment has been minimized.

This comment has been minimized.

virajjasani commented Aug 13, 2020

bsglz commented Aug 13, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

busbey Aug 14, 2020

bsglz Aug 14, 2020

busbey Aug 27, 2020

bsglz Aug 28, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

bsglz commented Aug 20, 2020

busbey left a comment

bsglz commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

bsglz commented Sep 7, 2020

busbey left a comment

bsglz commented Sep 16, 2020

HBASE-24875 Remove the force param for unassign since it dose not take effect any more #2254

HBASE-24875 Remove the force param for unassign since it dose not take effect any more #2254

Conversation

bsglz commented Aug 13, 2020 • edited Loading

This comment has been minimized.

wchevreuil left a comment

Choose a reason for hiding this comment

bsglz commented Aug 13, 2020

This comment has been minimized.

virajjasani commented Aug 13, 2020

bsglz commented Aug 13, 2020

This comment has been minimized.

This comment has been minimized.

virajjasani commented Aug 13, 2020

bsglz commented Aug 13, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

busbey Aug 14, 2020

Choose a reason for hiding this comment

bsglz Aug 14, 2020

Choose a reason for hiding this comment

busbey Aug 27, 2020

Choose a reason for hiding this comment

bsglz Aug 28, 2020

Choose a reason for hiding this comment

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

Apache-HBase commented Aug 14, 2020

bsglz commented Aug 20, 2020

busbey left a comment

Choose a reason for hiding this comment

bsglz commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

Apache-HBase commented Aug 28, 2020

bsglz commented Sep 7, 2020

busbey left a comment

Choose a reason for hiding this comment

bsglz commented Sep 16, 2020

bsglz commented Aug 13, 2020 •

edited

Loading