HBASE-25065 WAL archival to be done by a separate thread #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Oct 8, 2020
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
Show resolved
Hide resolved
| if (retry > archiveRetries) { | ||
| LOG.error("Failed log archiving for the log {},", log.getFirst(), e); | ||
| if (this.server != null) { | ||
| this.server.abort("Failed log archiving", e); |
There was a problem hiding this comment.
This the only reason for passing server? There is an Abortable Interface. Pass in an Abortable Interface instead (the server is an implementation of an Abortable so you could pass server).
There was a problem hiding this comment.
Fixed this every where.
| @@ -86,6 +87,7 @@ | |||
| public static final String WAL_ENABLED = "hbase.regionserver.hlog.enabled"; | |||
|
|
|||
| final String factoryId; | |||
| final Server server; | |||
There was a problem hiding this comment.
Yeah, too much if it is only being used to abort. Just pass an Abortable.
| } | ||
|
|
||
| @Override | ||
| protected void archiveRetriable(Pair<Path, Long> localLogsToArchive) { |
|
|
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Oct 8, 2020
| @@ -482,6 +505,8 @@ protected SyncFuture initialValue() { | |||
| this.walTooOldNs = TimeUnit.SECONDS.toNanos(conf.getInt( | |||
| SURVIVED_TOO_LONG_SEC_KEY, SURVIVED_TOO_LONG_SEC_DEFAULT)); | |||
| this.useHsync = conf.getBoolean(HRegion.WAL_HSYNC_CONF_KEY, HRegion.DEFAULT_WAL_HSYNC); | |||
| archiveRetries = this.conf.getInt("hbase.regionserver.walroll.archive.retries", 0); | |||
There was a problem hiding this comment.
Default is no retries?
Will the retry ever work? Will it be regular occurence?
There was a problem hiding this comment.
Ideally if the WAL FS is having an issue then this archive may also fail. By default we will try it (mandatory) once (so retries are 0) - then if this new config is set to a non-zero value we will try to repeat it for the configured times. Generally we are not going to configure it to a non-zero value.
| } | ||
| } | ||
|
|
||
| protected void archiveRetryable(final Pair<Path, Long> log) { |
There was a problem hiding this comment.
nit: just name it archive ? That it retries is an internal affair.
|
🎊 +1 overall
This message was automatically generated. |
ramkrish86
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
Looks to be fine. Will commit this unless objections. |
|
🎊 +1 overall
This message was automatically generated. |
ramkrish86
force-pushed
the
HBASE-25065
branch
from
a0b0b2c
to
2a12ea8
Compare
|
💔 -1 overall
This message was automatically generated. |
1 similar comment
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ndimiduk
reviewed
Oct 12, 2020
| import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; | ||
| import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
|
|
||
|
|
There was a problem hiding this comment.
nit: why all the extra whitespace?
| @@ -482,6 +505,8 @@ protected SyncFuture initialValue() { | |||
| this.walTooOldNs = TimeUnit.SECONDS.toNanos(conf.getInt( | |||
| SURVIVED_TOO_LONG_SEC_KEY, SURVIVED_TOO_LONG_SEC_DEFAULT)); | |||
| this.useHsync = conf.getBoolean(HRegion.WAL_HSYNC_CONF_KEY, HRegion.DEFAULT_WAL_HSYNC); | |||
| archiveRetries = this.conf.getInt("hbase.regionserver.walroll.archive.retries", 0); | |||
There was a problem hiding this comment.
Introducing a new configuration is a hint that this is too "big/complex" to add on a patch release.
|
|
||
| protected void archive(final Pair<Path, Long> log) { | ||
| int retry = 1; | ||
| while (true) { |
There was a problem hiding this comment.
No backoff of any kind in the retry mechanism?
| if (AbstractFSWALProvider.getNumRolledLogFiles(log) > 0) { | ||
| assertTrue(AbstractFSWALProvider.getLogFileSize(log) > 0); | ||
| } else { | ||
| for (int i = 0; i < 10; i++) { |
There was a problem hiding this comment.
This will be a flaky test. Please use the waitFor pattern already provided on the testing utility class.
ndimiduk
reviewed
Oct 12, 2020
| (Throwable) Mockito.anyObject()); | ||
| break; | ||
| } catch (WantedButNotInvoked t) { | ||
| Threads.sleep(1); |
There was a problem hiding this comment.
This will be a flaky test. Please use the waitFor pattern already provided on the testing utility class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…separate thread