Backport "HBASE-24628 Region normalizer now respects a rate limit" to branch-2 #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a rate limiter for the normalizer. Implemented in terms of MB/sec of affacted region size (the same metrics used to make normalization decisions). Uses Guava `RateLimiter` to perform the resource accounting. `RateLimiter` works by blocking (uninterruptible 😖) the calling thread. Thus, the whole construction of the normalizer subsystem needed refactoring. See the provided `package-info.java` for an overview of this new structure. Introduces a new configuration, `hbase.normalizer.throughput.max_bytes_per_sec`, for specifying a limit on the throughput of actions executed by the normalizer. Note that while this configuration value is in bytes, the minimum honored valued `1_000_000`. Supports values configured using the human-readable suffixes honored by `Configuration.getLongBytes` Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com> Signed-off-by: Michael Stack <stack@apache.org>
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a rate limiter for the normalizer. Implemented in terms of
MB/sec of affacted region size (the same metrics used to make
normalization decisions). Uses Guava
RateLimiterto perform theresource accounting.
RateLimiterworks by blocking (uninterruptible😖) the calling thread. Thus, the whole construction of the normalizer
subsystem needed refactoring. See the provided
package-info.javaforan overview of this new structure.
Introduces a new configuration,
hbase.normalizer.throughput.max_bytes_per_sec, for specifying alimit on the throughput of actions executed by the normalizer. Note
that while this configuration value is in bytes, the minimum honored
valued
1_000_000. Supports values configured using thehuman-readable suffixes honored by
Configuration.getLongBytesSigned-off-by: Viraj Jasani vjasani@apache.org
Signed-off-by: Huaxiang Sun huaxiangsun@apache.com
Signed-off-by: Michael Stack stack@apache.org