-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25272 Support scan on a specific replica #2645
Conversation
Check whether we could pass all the existing UTs. Need to add a test to verify the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. +1 pending test result.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
Show resolved
Hide resolved
I can integrate with your patch with the meta replica client patch. In the meta replica client patch, there is already test which covers that scan over a specific replica region only goes to that region. |
And we need to touch hbase-server module to trigger tests there. The tests in hbase-client does not run most of read replica tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github is in trouble? I'm not reviewing...
Had a little trouble when implementing the UT, can not get expect result as we always go to primary... Let me check what's wrong here... |
Oh, shit, just a test problem... Let me prepare the PR... |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: stack <stack@apache.org> Signed-off-by: Huaxiang Sun <huaxiangsun@apache.org>
No description provided.