HBASE-25365 The log in move_servers_rsgroup is incorrect #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Dec 14, 2020
| @@ -1015,17 +1016,17 @@ private void moveServerRegionsFromGroup(Set<Address> movedServers, Set<Address> | |||
| assignmentFutures.add(Pair.newPair(region, future)); | |||
| } catch (IOException ioe) { | |||
| failedRegions.add(region.getRegionNameAsString()); | |||
| LOG.debug("Move region {} from group failed, will retry, current retry time is {}", | |||
| region.getShortNameToLog(), retry, ioe); | |||
| LOG.debug("Move region {} from server {} failed, will retry, current retry time is {}", | |||
There was a problem hiding this comment.
nit: 'server' in the log message is redundant; we are always moving between servers?
| if (failedRegions.isEmpty()) { | ||
| LOG.info("All regions from server(s) {} moved to target group {}.", movedServerNames, | ||
| targetGrp.getName()); | ||
| LOG.info("All regions from server(s) {} moved to source group {}.", movedServerNames, |
There was a problem hiding this comment.
Why not say, 'All regions from {} moved from {} to {}, movedServerNames, sourceGroupName, targetGroupName?
There was a problem hiding this comment.
The regions in movedServerNames originally belongs to the source group. So it should not say "move from sourceGroupName to targetGroupName". Maybe it can be like this: “All regions from {} are moved back to {}, movedServerNames, sourceGroupName”?
There was a problem hiding this comment.
If that is what is happening, then yes, your rephrasing makes more sense (IMO). Thanks.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-25365