HBASE-25451 Upgrade commons-io to 2.8.0 #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infraio
reviewed
Dec 29, 2020
| @@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc | |||
| HBaseFsck.createLockRetryCounterFactory(this.conf).create()); | |||
| } finally { | |||
| if (result != null) { | |||
| IOUtils.closeQuietly(result.getSecond()); | |||
| Closeables.close(result.getSecond(), true); | |||
There was a problem hiding this comment.
What is the difference about Closeables.close and IOUtils.close?
There was a problem hiding this comment.
Closeables.close(c, true) will swallow the IOException thrown while IOUtils.close will not.
There was a problem hiding this comment.
Seems there are three methods you used: Closeables.closeQuietly, Closeables.close, IOUtils.closeQuietly. Do we have a developer guide doc about what we recommend to use?
There was a problem hiding this comment.
Closeables.close will still throw IOExceptions on the method signature, so usually it is only suitable to be used in UT, where we are free to change the method signature.
IOUtils.closeQuietly will not throw any exceptions but you need to pass in a consumer to process the IOException(usually just a logging).
Closeables.closeQuietly is for closing Reader and InputStream, where we will not throw any exceptions.
There was a problem hiding this comment.
And in general, I do not have very strong opinion on forcing these rules, developers are free to use these methods, just not use a deprecated one...
There was a problem hiding this comment.
IOUtils.closeQuietly is also deprecated with a long time -- apache/commons-io@ce2b3e8
There was a problem hiding this comment.
As is Closeables#closeQuietly... google/guava#1118
There was a problem hiding this comment.
For IOUtils.closeQuietly, now it provides a version with a consumer parameter to process the IOException which is not deprecated.
For Closeables.closeQuirtly, the version which takes a Closeable as parameter has already been removed for a long time, but the version which takes a InputStream or a Reader is still available and is not deprecated.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Dec 31, 2020
| @@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc | |||
| HBaseFsck.createLockRetryCounterFactory(this.conf).create()); | |||
| } finally { | |||
| if (result != null) { | |||
| IOUtils.closeQuietly(result.getSecond()); | |||
| Closeables.close(result.getSecond(), true); | |||
There was a problem hiding this comment.
IOUtils.closeQuietly is also deprecated with a long time -- apache/commons-io@ce2b3e8
| @@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc | |||
| HBaseFsck.createLockRetryCounterFactory(this.conf).create()); | |||
| } finally { | |||
| if (result != null) { | |||
| IOUtils.closeQuietly(result.getSecond()); | |||
| Closeables.close(result.getSecond(), true); | |||
There was a problem hiding this comment.
As is Closeables#closeQuietly... google/guava#1118
Apache9
added a commit
that referenced
this pull request
Dec 31, 2020
Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.