Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBase 22537 #307

Closed
wants to merge 29 commits into from
Closed

HBase 22537 #307

wants to merge 29 commits into from

Conversation

wchevreuil
Copy link
Contributor

This PR consists of two commits on top of branch-2.1:

  1. Changes from original patch proposed by sreenivasulureddy;
  2. My suggestion to just remove the "non-primary" replica from AM map of regions per RS.

I had proposed a minor change in my commit because original fix would cause region close notification eve for read replicas, I'm not sure this is ideal.

Additional work may be needed on existing test, so it may be easy to collaborate via this PR. I can then squash all commits into a single one once we are ready to apply the fix.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2.1 Compile Tests _
+1 mvninstall 255 branch-2.1 passed
+1 compile 52 branch-2.1 passed
+1 checkstyle 80 branch-2.1 passed
+1 shadedjars 251 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 129 branch-2.1 passed
+1 javadoc 33 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 249 the patch passed
+1 compile 53 the patch passed
+1 javac 53 the patch passed
+1 checkstyle 79 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 251 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1013 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 findbugs 136 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
+1 unit 8314 hbase-server in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
11346
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/artifact/out/Dockerfile
GITHUB PR #307
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5ab1a4034771 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.1 / 35521d4
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/testReport/
Max. process+thread count 4608 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 77 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2.1 Compile Tests _
+1 mvninstall 315 branch-2.1 passed
+1 compile 81 branch-2.1 passed
+1 checkstyle 90 branch-2.1 passed
+1 shadedjars 307 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 173 branch-2.1 passed
+1 javadoc 42 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 318 the patch passed
+1 compile 68 the patch passed
+1 javac 68 the patch passed
-1 checkstyle 92 hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 310 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1285 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 findbugs 191 the patch passed
+1 javadoc 39 the patch passed
_ Other Tests _
-1 unit 14901 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
18717
Reason Tests
Failed junit tests hadoop.hbase.client.TestAdmin1
hadoop.hbase.quotas.TestSpaceQuotas
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/Dockerfile
GITHUB PR #307
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4976c0541afc 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.1 / 35521d4
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/testReport/
Max. process+thread count 5213 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

sreenivasulureddy and others added 3 commits July 3, 2019 09:55
…leting table successfully and restarting RegionServer

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…changes should be addressed on its own jira issue.
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 8 #307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #307
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet and others added 15 commits July 3, 2019 15:08
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…ermissions on created table

Signed-off-by: Reid Chan <reidchan@apache.org>
…hecker and PeriodicMemStoreFlusher

Signed-off-by: Zach York <zyork@apache.org>
Signed-off-by: Xu Cang <xucang@apache.org>
…rsions

Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 6a068da)
…pache#281)

HBASE-22520 Avoid possible NPE while performing seekBefore in HalfStoreFileReader
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes apache#328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
…component ops (apache#329)

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Michael Stack <stack@apache.org>
)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
…should skip store files for unknown column families (apache#344)

Signed-off-by: Guanghao Zhang <zghao@apache.org>
…tionQueueStorage

Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
Apache9 and others added 6 commits July 3, 2019 15:08
…sign forever fail

    Signed-off-by: Allan Yang <allan163@apache.org>
    Signed-off-by: Michael Stack <stack@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
Signed-off-by: Sean Busbey <busbey@apache.org>
…able" by Jim R. Wilson

Signed-off-by: Sean Busbey <busbey@apache.org>
@wchevreuil
Copy link
Contributor Author

Rebased this PR with branch-2.1.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 7 #307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #307
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 9 #307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #307
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/6/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 8 #307 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #307
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-307/7/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil closed this Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.