HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… #318

openinx · 2019-06-17T09:56:08Z

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility

anoopsjohn · 2019-06-17T10:06:39Z

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java

+  public static final String BUFFER_SIZE_KEY = "hbase.server.allocator.buffer.size";
+
+  @Deprecated
+  static final String DEPRECATED_MAX_BUFFER_COUNT_KEY = "hbase.ipc.server.reservoir.initial.max";


These old configs are there in code already right? Some other place. Also referring there? Or you removed all those? Sorry I did not review that jira then. Do we by chance referring these configs in config.xml?

We removed all of them in https://issues.apache.org/jira/browse/HBASE-21916 before. Did a finding search about the hbase.ipc.server.reservoir.initial.max & hbase.ipc.server.reservoir.initial.buffer.size, no other places are refering the deprecated configs now except the document.
So here it should be OK.

anoopsjohn

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java

Apache-HBase · 2019-06-17T11:10:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	155	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21879 Compile Tests _
+1	mvninstall	272	HBASE-21879 passed
+1	compile	21	HBASE-21879 passed
+1	checkstyle	23	HBASE-21879 passed
+1	shadedjars	283	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	39	HBASE-21879 passed
+1	javadoc	19	HBASE-21879 passed
		_ Patch Compile Tests _
+1	mvninstall	256	the patch passed
+1	compile	21	the patch passed
+1	javac	21	the patch passed
-1	checkstyle	23	hbase-common: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	275	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	775	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	46	the patch passed
+1	javadoc	19	the patch passed
		_ Other Tests _
+1	unit	155	hbase-common in the patch passed.
+1	asflicense	10	The patch does not generate ASF License warnings.
		2720

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/artifact/out/Dockerfile
GITHUB PR	#318
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d852da472fbe 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21879 / `7840613`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/artifact/out/diff-checkstyle-hbase-common.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/testReport/
Max. process+thread count	255 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility

openinx · 2019-06-17T11:37:56Z

Updated the patch to address the checkstyle issues.

Reidddddd · 2019-06-17T11:45:51Z

+1, after QA warning addressed.

Apache-HBase · 2019-06-17T12:23:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21879 Compile Tests _
+1	mvninstall	247	HBASE-21879 passed
+1	compile	22	HBASE-21879 passed
+1	checkstyle	22	HBASE-21879 passed
+1	shadedjars	269	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	40	HBASE-21879 passed
+1	javadoc	20	HBASE-21879 passed
		_ Patch Compile Tests _
+1	mvninstall	239	the patch passed
+1	compile	21	the patch passed
+1	javac	21	the patch passed
+1	checkstyle	22	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	265	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	746	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	46	the patch passed
+1	javadoc	21	the patch passed
		_ Other Tests _
+1	unit	170	hbase-common in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		2495

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/artifact/out/Dockerfile
GITHUB PR	#318
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 16b881aa5edc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21879 / `7840613`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/testReport/
Max. process+thread count	366 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-318/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (#318)

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (apache#318)

openinx requested review from anoopsjohn, Apache9, ramkrish86 and Reidddddd June 17, 2019 09:58

anoopsjohn reviewed Jun 17, 2019

View reviewed changes

Reidddddd reviewed Jun 17, 2019

View reviewed changes

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java Show resolved Hide resolved

Reidddddd reviewed Jun 17, 2019

View reviewed changes

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java Show resolved Hide resolved

Reidddddd self-requested a review June 17, 2019 10:14

Reidddddd reviewed Jun 17, 2019

View reviewed changes

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java Show resolved Hide resolved

Reidddddd self-requested a review June 17, 2019 10:43

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

ec127d6

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility

openinx force-pushed the HBASE-21879 branch from c4c93b4 to ec127d6 Compare June 17, 2019 11:37

Reidddddd approved these changes Jun 17, 2019

View reviewed changes

openinx merged commit 0d12281 into apache:HBASE-21879 Jun 17, 2019

asfgit pushed a commit that referenced this pull request Jun 18, 2019

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

afaf7a9

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (#318)

asfgit pushed a commit that referenced this pull request Jun 24, 2019

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

686847c

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (#318)

openinx added a commit to openinx/hbase that referenced this pull request Jun 25, 2019

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

d34c4a0

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (apache#318)

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.…

95c5620

…size & hbase.ipc.server.reservoir.initial.max for HBase2.x compatibility (apache#318)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… #318

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… #318

Uh oh!

openinx commented Jun 17, 2019

Uh oh!

anoopsjohn Jun 17, 2019

Uh oh!

openinx Jun 17, 2019

Uh oh!

anoopsjohn left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 17, 2019

Uh oh!

openinx commented Jun 17, 2019

Uh oh!

Reidddddd commented Jun 17, 2019

Uh oh!

Apache-HBase commented Jun 17, 2019

Uh oh!

Uh oh!

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… #318

HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… #318

Uh oh!

Conversation

openinx commented Jun 17, 2019

Uh oh!

anoopsjohn Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

openinx Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

anoopsjohn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 17, 2019

Uh oh!

openinx commented Jun 17, 2019

Uh oh!

Reidddddd commented Jun 17, 2019

Uh oh!

Apache-HBase commented Jun 17, 2019

Uh oh!

Uh oh!