Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26096 Cleanup the deprecated methods in HBTU related classes and format code #3503

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 19, 2021

No description provided.

@Apache9 Apache9 self-assigned this Jul 19, 2021
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 5m 13s master passed
+1 💚 checkstyle 1m 56s master passed
+1 💚 spotbugs 3m 50s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 compile 5m 9s the patch passed
-0 ⚠️ javac 0m 30s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️ javac 3m 11s hbase-server generated 35 new + 158 unchanged - 35 fixed = 193 total (was 193)
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-zookeeper
-0 ⚠️ checkstyle 1m 3s hbase-server: The patch generated 7 new + 80 unchanged - 87 fixed = 87 total (was 167)
+1 💚 checkstyle 0m 18s hbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
-0 ⚠️ whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 18m 7s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 4m 40s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
59m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3503
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 5cb1d3dda910 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bc2fc0
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 changed the title HBASE-26096 Cleanup the deprecated methods in HBTU related classes HBASE-26096 Cleanup the deprecated methods in HBTU related classes and format code Jul 19, 2021
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 53s master passed
+1 💚 compile 5m 54s master passed
+1 💚 checkstyle 2m 21s master passed
+1 💚 spotbugs 4m 32s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 39s the patch passed
+1 💚 compile 6m 0s the patch passed
+1 💚 javac 0m 51s hbase-common in the patch passed.
+1 💚 javac 0m 29s hbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️ javac 3m 11s hbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚 javac 0m 47s hbase-mapreduce in the patch passed.
+1 💚 javac 0m 42s hbase-it in the patch passed.
+1 💚 checkstyle 0m 24s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-zookeeper
-0 ⚠️ checkstyle 1m 5s hbase-server: The patch generated 1 new + 77 unchanged - 94 fixed = 78 total (was 171)
+1 💚 checkstyle 0m 18s hbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 18m 8s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 5m 32s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
64m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3503
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 59e33627be65 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8bc2fc0
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@nyl3532016 nyl3532016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 4m 47s master passed
+1 💚 compile 7m 38s master passed
+1 💚 checkstyle 2m 40s master passed
+1 💚 spotbugs 5m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 7s the patch passed
+1 💚 compile 7m 58s the patch passed
+1 💚 javac 0m 58s hbase-common in the patch passed.
+1 💚 javac 0m 34s hbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️ javac 4m 25s hbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚 javac 1m 7s hbase-mapreduce in the patch passed.
+1 💚 javac 0m 54s hbase-it in the patch passed.
+1 💚 checkstyle 0m 28s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 16s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 1m 23s hbase-server: The patch generated 0 new + 77 unchanged - 94 fixed = 77 total (was 171)
+1 💚 checkstyle 0m 20s hbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 checkstyle 0m 18s The patch passed checkstyle in hbase-it
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 26m 0s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 9m 0s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 17s The patch does not generate ASF License warnings.
87m 27s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3503
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 3e3b38faeb97 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4a3c7d7
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 27, 2021

It is a bit strange that once we use the builder instead of constructor of MiniDFSCluster, some tests will fail. Let me revert back to use constructor and open a separated issue to address it.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 3m 41s master passed
+1 💚 compile 5m 55s master passed
+1 💚 checkstyle 2m 18s master passed
+1 💚 spotbugs 4m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 41s the patch passed
+1 💚 compile 5m 52s the patch passed
+1 💚 javac 0m 47s hbase-common in the patch passed.
+1 💚 javac 0m 29s hbase-zookeeper generated 0 new + 96 unchanged - 1 fixed = 96 total (was 97)
-0 ⚠️ javac 3m 8s hbase-server generated 40 new + 153 unchanged - 40 fixed = 193 total (was 193)
+1 💚 javac 0m 46s hbase-mapreduce in the patch passed.
+1 💚 javac 0m 42s hbase-it in the patch passed.
+1 💚 checkstyle 0m 23s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 0m 13s The patch passed checkstyle in hbase-zookeeper
+1 💚 checkstyle 1m 2s hbase-server: The patch generated 0 new + 77 unchanged - 94 fixed = 77 total (was 171)
+1 💚 checkstyle 0m 18s hbase-mapreduce: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 checkstyle 0m 17s The patch passed checkstyle in hbase-it
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 18m 17s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 5m 29s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
66m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3503
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 4c07799b44c6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 02d263e
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 30s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s master passed
+1 💚 compile 2m 39s master passed
+1 💚 shadedjars 8m 21s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 51s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 compile 2m 39s the patch passed
+1 💚 javac 2m 39s the patch passed
+1 💚 shadedjars 8m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 50s the patch passed
_ Other Tests _
+1 💚 unit 1m 39s hbase-common in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 151m 25s hbase-server in the patch passed.
+1 💚 unit 10m 57s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 16s hbase-it in the patch passed.
209m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3503
Optional Tests javac javadoc unit shadedjars compile
uname Linux cc48b28fdb2d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 02d263e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/testReport/
Max. process+thread count 4676 (vs. ulimit of 30000)
modules C: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 8m 31s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 6m 32s master passed
+1 💚 compile 3m 55s master passed
+1 💚 shadedjars 10m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 5m 52s the patch passed
+1 💚 compile 4m 2s the patch passed
+1 💚 javac 4m 2s the patch passed
+1 💚 shadedjars 10m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s the patch passed
_ Other Tests _
+1 💚 unit 2m 44s hbase-common in the patch passed.
+1 💚 unit 1m 1s hbase-zookeeper in the patch passed.
+1 💚 unit 233m 58s hbase-server in the patch passed.
+1 💚 unit 17m 26s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 21s hbase-it in the patch passed.
314m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3503
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6c996045a834 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 02d263e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/testReport/
Max. process+thread count 3308 (vs. ulimit of 30000)
modules C: hbase-common hbase-zookeeper hbase-server hbase-mapreduce hbase-it U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3503/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 5f09505 into apache:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants