-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ilter could throw AssertionError (backport of HBASE-19863)
💔 -1 overall
This message was automatically generated. |
…ilter could throw AssertionError (backport of HBASE-19863) + checkstyle adapted.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…ilter could throw AssertionError (backport of HBASE-19863) + checkstyle adapted.
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Backport HBASE-19863? First skimmed(not in detailed), looks like they are quite different? |
@Reidddddd So, yeah. My first description was not updated property. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestIsDeleteFailure.java
Outdated
Show resolved
Hide resolved
…ilter could throw AssertionError (backport of HBASE-19863) + add a line at the end of file
LGTM. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)
Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check.
which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem.
When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it requires reseek to find right next cell.
I created a backport patch of HBASE-19863 and a part of HBASE-17958.
Exact same testcase included. And changed StoreScanner due to the difference of codes.