-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27793 Make HBCK be able to report unknown servers #5229
Conversation
validated the patch against real cluster.
with the patch unknown servers reported.
|
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
I think we'd better make the title like The current title seems like it is incorrect to report unknown servers as inconsistencies... |
Thanks for review @Apache9. Changed the title as suggested. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
unknownServers.stream().forEach(serverName -> { | ||
errors.reportError(ERROR_CODE.UNKNOWN_SERVER, | ||
"Found unknown server, " | ||
+ " some of the regions hold by this server may not get assigned. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: hold -> held.
also we could remove an extra space between "server, some"
Add better correct the comments which pointed out by @NihalJain above before merging. Thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@chrajeshbabu Any updates here? |
@Apache9 going to commit it today. Thanks. |
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
No description provided.