HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
joshelser
requested changes
Sep 4, 2019
| @@ -764,6 +765,9 @@ int getNumRegions(TableName table) throws IOException { | |||
| List<RegionInfo> regions = this.conn.getAdmin().getRegions(table); | |||
| if (regions == null) { | |||
| return 0; | |||
| } else { | |||
There was a problem hiding this comment.
Nit: the else branch is unnecessary. Just make this if (regions==null) {return 0;} RegionReplicaUtil... (but properly formatted).
There was a problem hiding this comment.
Hi @joshelser , Thanks for the review. Did all the changes and pushed. :)
| p.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1), Bytes.toBytes("to"), | ||
| Bytes.toBytes("reject")); | ||
| // Adding a sleep for 5 sec, so all the chores run and to void flakiness of the test. | ||
| Thread.sleep(5000); |
There was a problem hiding this comment.
👎 Make this an explicit check. What do you need to propagate so that this test can pass? The RegionServerQuotaManager needs to be aware of the quota that was set? You can look at that via HBaseTestingUtility and the HRegionServer object you can get from there.
Is that clear? Like your other PR, there should be examples of doing this already in the o.a.h.h.quotas package.
There was a problem hiding this comment.
Not required here since verifyViolation() has NUM_RETRIES as 10 and also has some wait. So removing the Thread.Sleep here. Even without it, testcase will always pass.
|
|
||
| @Test | ||
| public void testSetQuotaWithRegionReplicaMultipleRegion() throws Exception { | ||
| setQuotaAndVerifyForRegionReplication(5, 3, SpaceViolationPolicy.NO_INSERTS); |
There was a problem hiding this comment.
Is it intentional that this is 5 and the other lines are 6?
There was a problem hiding this comment.
Not intentional. changed it to 6 only.
|
|
||
| @Test | ||
| public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception { | ||
| setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.NO_INSERTS); |
There was a problem hiding this comment.
Turn this into a for-loop with SpaceViolationPolicy.values()?
joshelser
approved these changes
Sep 6, 2019
|
💔 -1 overall
This message was automatically generated. |
Looks like the new test (and all of the old quota tests) passed. Will get this in. |
|
Thank you @joshelser :-) |
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes #570 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes #570 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes #570 Signed-off-by: Josh Elser <elserj@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…ons for a table Closes apache#570 Signed-off-by: Josh Elser <elserj@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…ons for a table Closes apache#570 Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit 973ec21) Change-Id: I1a9dd12df50867672042e7cf4738ea94896f6085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space Quota: Space Quota Issue: If a table is created with region replica then quota calculation is not happening
Steps:
1: Create a table with 100 regions with region replica 3
2: Observe that 'hbase:quota' table doesn't have entry of usage for this table So In UI only policy Limit and Policy is shown but not Usage and State.
Reason:
It looks like File system utilization core is sending data of 100 reiogns but not the size of region replicas.
But in quota observer chore, it is considering total region(actual regions+ replica reasons)
So the ratio of reported regions is less then configured percentRegionsReportedThreshold.
So quota calculation is not happening