Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 #6098

ndimiduk · 2024-07-19T12:06:15Z

No description provided.

apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>

charlesconnell · 2024-07-19T12:25:36Z

This and the other 2.x PRs for this ticket require a change to HBaseAdmin to use the new QuotaRetriever constructor

ndimiduk · 2024-07-19T12:34:52Z

This and the other 2.x PRs for this ticket require a change to HBaseAdmin to use the new QuotaRetriever constructor

Okay. Let me do a search for other usages of this class on branch-2.

ndimiduk · 2024-07-19T12:35:10Z

Or would you prefer to handle the branch-2 backport?

charlesconnell · 2024-07-19T12:39:31Z

I trust you!

ndimiduk · 2024-07-19T14:36:10Z

I don't find any more static usage on branch-2.

charlesconnell

looks good to me

Apache-HBase · 2024-07-22T08:31:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		branch-2 passed
+1 💚	compile	3m 37s		branch-2 passed
+1 💚	checkstyle	0m 58s		branch-2 passed
+1 💚	spotbugs	2m 25s		branch-2 passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 53s		the patch passed
+1 💚	compile	3m 37s		the patch passed
+1 💚	javac	3m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 57s		the patch passed
+1 💚	spotbugs	2m 41s		the patch passed
+1 💚	hadoopcheck	15m 29s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 22s		The patch does not generate ASF License warnings.
		40m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 0d7b8d5bf842 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-22T12:06:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s		branch-2 passed
+1 💚	compile	1m 12s		branch-2 passed
+1 💚	javadoc	0m 44s		branch-2 passed
+1 💚	shadedjars	6m 10s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	1m 10s		the patch passed
+1 💚	javac	1m 10s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	shadedjars	6m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 18s		hbase-client in the patch passed.
+1 💚	unit	219m 27s		hbase-server in the patch passed.
		255m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 1ed73742169c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/testReport/
Max. process+thread count	4398 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2024-07-22T13:34:16Z

WTF jenkins?

Apache-HBase · 2024-07-22T14:15:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 4s		branch-2 passed
+1 💚	compile	3m 35s		branch-2 passed
+1 💚	checkstyle	0m 54s		branch-2 passed
+1 💚	spotbugs	2m 16s		branch-2 passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	3m 31s		the patch passed
+1 💚	javac	3m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 51s		the patch passed
+1 💚	spotbugs	2m 33s		the patch passed
+1 💚	hadoopcheck	15m 55s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		40m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux bb56502b19d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981

+1 LGTM

Apache-HBase · 2024-07-22T18:23:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 20s		branch-2 passed
+1 💚	compile	1m 28s		branch-2 passed
+1 💚	javadoc	0m 49s		branch-2 passed
+1 💚	shadedjars	6m 10s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	1m 14s		the patch passed
+1 💚	javac	1m 14s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed
+1 💚	shadedjars	6m 11s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 20s		hbase-client in the patch passed.
-1 ❌	unit	250m 17s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		288m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 59e7eb967ae9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count	4161 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-22T19:54:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 45s		branch-2 passed
+1 💚	compile	1m 56s		branch-2 passed
+1 💚	javadoc	1m 7s		branch-2 passed
+1 💚	shadedjars	6m 33s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 34s		the patch passed
+1 💚	compile	1m 51s		the patch passed
+1 💚	javac	1m 51s		the patch passed
+1 💚	javadoc	1m 7s		the patch passed
+1 💚	shadedjars	6m 43s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 28s		hbase-client in the patch passed.
-1 ❌	unit	334m 9s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		379m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 280cbbe15759 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count	4296 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-22T20:07:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s		branch-2 passed
+1 💚	compile	1m 49s		branch-2 passed
+1 💚	javadoc	1m 0s		branch-2 passed
+1 💚	shadedjars	6m 37s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 37s		the patch passed
+1 💚	compile	1m 39s		the patch passed
+1 💚	javac	1m 39s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed
+1 💚	shadedjars	6m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 16s		hbase-client in the patch passed.
+1 💚	unit	347m 41s		hbase-server in the patch passed.
		392m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6098
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bf954cd2d1a4 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b4bd02c`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count	4610 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

HBASE-28716 Users of QuotaRetriever should pass an existing connection (

305b08e

apache#6065) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jul 19, 2024

This comment has been minimized.

Sign in to view

charlesconnell approved these changes Jul 19, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

addendum for branch-2

b4bd02c

ndimiduk force-pushed the 28716-branch-2 branch from 704947d to b4bd02c Compare July 22, 2024 07:49

pankaj72981 approved these changes Jul 22, 2024

View reviewed changes

ndimiduk merged commit fc4e1f9 into apache:branch-2 Jul 23, 2024
1 check failed

ndimiduk deleted the 28716-branch-2 branch July 23, 2024 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 #6098

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 #6098

ndimiduk commented Jul 19, 2024

charlesconnell commented Jul 19, 2024

ndimiduk commented Jul 19, 2024

ndimiduk commented Jul 19, 2024

charlesconnell commented Jul 19, 2024

This comment has been minimized.

ndimiduk commented Jul 19, 2024

This comment has been minimized.

charlesconnell left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

ndimiduk commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

pankaj72981 left a comment

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 #6098

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 #6098

Conversation

ndimiduk commented Jul 19, 2024

charlesconnell commented Jul 19, 2024

ndimiduk commented Jul 19, 2024

ndimiduk commented Jul 19, 2024

charlesconnell commented Jul 19, 2024

This comment has been minimized.

ndimiduk commented Jul 19, 2024

This comment has been minimized.

charlesconnell left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

ndimiduk commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

pankaj72981 left a comment

Choose a reason for hiding this comment

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024

Apache-HBase commented Jul 22, 2024