Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28655 IllegalArgumentException: Illegal bufferSize thrown when hbase.io.compress.zstd.buffersize is not configured #6121

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pankaj72981
Copy link
Contributor

HADOOP-18810 added io.compression.codec.zstd.buffersize in core-default.xml with default value as 0, so default value of hbase.io.compress.zstd.buffersize will become 0 instead of ZSTD_BUFFER_SIZE_DEFAULT (256 * 1024) when not configured in hbase-site.xml.

(cherry picked from commit 73f2710)

…hbase.io.compress.zstd.buffersize is not configured (apache#6114)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
@pankaj72981 pankaj72981 added the backport This PR is a back port of some issue or issues already committed to master label Jul 25, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 34s branch-2 passed
+1 💚 compile 0m 26s branch-2 passed
+1 💚 javadoc 0m 22s branch-2 passed
+1 💚 shadedjars 5m 21s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 23s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 javadoc 0m 21s the patch passed
+1 💚 shadedjars 5m 18s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 57s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 2m 28s hbase-compression-zstd in the patch passed.
23m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6121
Optional Tests javac javadoc unit compile shadedjars
uname Linux 7b7c77780406 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2ed3a81
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
Max. process+thread count 761 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 3m 3s branch-2 passed
+1 💚 compile 0m 35s branch-2 passed
+1 💚 javadoc 0m 29s branch-2 passed
+1 💚 shadedjars 5m 37s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 compile 0m 35s the patch passed
+1 💚 javac 0m 35s the patch passed
+1 💚 javadoc 0m 28s the patch passed
+1 💚 shadedjars 5m 34s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 0s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 2m 52s hbase-compression-zstd in the patch passed.
25m 53s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6121
Optional Tests javac javadoc unit compile shadedjars
uname Linux 19d2a8eaf5a4 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2ed3a81
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
Max. process+thread count 915 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 35s branch-2 passed
+1 💚 compile 0m 53s branch-2 passed
+1 💚 javadoc 0m 32s branch-2 passed
+1 💚 shadedjars 7m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 0m 34s the patch passed
+1 💚 javac 0m 34s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 6m 21s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 11s hbase-compression-aircompressor in the patch passed.
+1 💚 unit 3m 11s hbase-compression-zstd in the patch passed.
31m 33s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6121
Optional Tests javac javadoc unit compile shadedjars
uname Linux daeae706e1d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2ed3a81
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/testReport/
Max. process+thread count 760 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 36s branch-2 passed
+1 💚 compile 0m 56s branch-2 passed
+1 💚 checkstyle 0m 21s branch-2 passed
+1 💚 spotbugs 0m 57s branch-2 passed
+1 💚 spotless 0m 55s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 23s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 javac 0m 38s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 spotbugs 1m 20s the patch passed
+1 💚 hadoopcheck 18m 21s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
36m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6121
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 8a70dcf5e300 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 2ed3a81
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-zstd U: hbase-compression
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6121/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981 pankaj72981 merged commit c6e819e into apache:branch-2 Jul 25, 2024
1 check passed
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114) (#6121)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
(cherry picked from commit c6e819e)
pankaj72981 added a commit that referenced this pull request Jul 25, 2024
…hbase.io.compress.zstd.buffersize is not configured (#6114) (#6121)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Vineet Kumar Maheshwari <vineet.4008@gmail.com>
(cherry picked from commit 73f2710)
(cherry picked from commit c6e819e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants