-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29507: IntegrationTestBackupRestore is failing because it cannot restore from backup directory #7230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
taklwu
merged 1 commit into
apache:master
from
kgeisz:HBASE-29507-IntegrationTestBackupRestore-getting-OutOfMemoryError
Aug 19, 2025
Merged
HBASE-29507: IntegrationTestBackupRestore is failing because it cannot restore from backup directory #7230
taklwu
merged 1 commit into
apache:master
from
kgeisz:HBASE-29507-IntegrationTestBackupRestore-getting-OutOfMemoryError
Aug 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifbc9429179bb83b91104341668c7c5b94acb9ea3
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
taklwu
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kota-SH
approved these changes
Aug 19, 2025
kgeisz
added a commit
to kgeisz/hbase
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
kgeisz
added a commit
to kgeisz/hbase
that referenced
this pull request
Aug 20, 2025
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
taklwu
added a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-29507
This pull request reduces the value for
DEFAULT_ROWS_IN_ITERATION
in IntegrationTestBackupRestore.java from 500,000 to 10,000. The change prevents an OutOfMemoryError from occurring when running IntegrationTestBackupRestore locally. The error was discovered while testing the fix for PR #7203. If we still want to use 500,000 rows for an actual integration test on a distributed cluster, then the row count can be overridden via the command line by using therows_in_iteration
arg (seeROWS_PER_ITERATION_KEY
on this line).