Skip to content

Conversation

kgeisz
Copy link
Contributor

@kgeisz kgeisz commented Aug 19, 2025

https://issues.apache.org/jira/browse/HBASE-29507

This pull request reduces the value for DEFAULT_ROWS_IN_ITERATION in IntegrationTestBackupRestore.java from 500,000 to 10,000. The change prevents an OutOfMemoryError from occurring when running IntegrationTestBackupRestore locally. The error was discovered while testing the fix for PR #7203. If we still want to use 500,000 rows for an actual integration test on a distributed cluster, then the row count can be overridden via the command line by using the rows_in_iteration arg (see ROWS_PER_ITERATION_KEY on this line).

Change-Id: Ifbc9429179bb83b91104341668c7c5b94acb9ea3
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 40s master passed
+1 💚 compile 0m 26s master passed
+1 💚 javadoc 0m 18s master passed
+1 💚 shadedjars 6m 41s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 11s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 javadoc 0m 13s the patch passed
+1 💚 shadedjars 6m 25s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 53s hbase-it in the patch passed.
23m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7230/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7230
Optional Tests javac javadoc unit compile shadedjars
uname Linux e26a5daf5368 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 03f1417
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7230/1/testReport/
Max. process+thread count 624 (vs. ulimit of 30000)
modules C: hbase-it U: hbase-it
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7230/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 4m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 4m 21s master passed
+1 💚 compile 0m 43s master passed
+1 💚 checkstyle 0m 17s master passed
+1 💚 spotbugs 1m 5s master passed
+1 💚 spotless 1m 48s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 9s the patch passed
+1 💚 compile 0m 41s the patch passed
+1 💚 javac 0m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 spotbugs 0m 45s the patch passed
+1 💚 hadoopcheck 17m 28s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 54s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
51m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7230/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7230
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 549f77712e65 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 03f1417
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-it U: hbase-it
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7230/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taklwu taklwu merged commit 20b837e into apache:master Aug 19, 2025
1 check passed
kgeisz added a commit to kgeisz/hbase that referenced this pull request Aug 20, 2025
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
kgeisz added a commit to kgeisz/hbase that referenced this pull request Aug 20, 2025
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
taklwu added a commit that referenced this pull request Aug 20, 2025
taklwu added a commit that referenced this pull request Aug 20, 2025
…" (#7237)

This reverts commit 20b837e.

Reviewed by: Kevin Geiszler <kevin.j.geiszler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants