Skip to content

HBASE-29562 Add RegionServer Metrics for excluded DataNodes #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

HBASE-29562 Add RegionServer Metrics for excluded DataNodes #7260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,4 +647,10 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo
"Count of scanners which were expired due to scanner lease timeout";
String CURRENT_REGION_CACHE_RATIO = "currentRegionCacheRatio";
String CURRENT_REGION_CACHE_RATIO_DESC = "The percentage of caching completed for this region.";

String EXCLUDE_DATA_NODES_COUNT = "excludedDataNodesCount";
String EXCLUDE_DATA_NODES_COUNT_DESC =
"Count of slow/connect error DataNodes excluded during WAL write operation";
String EXCLUDE_DATA_NODES_DETAILS = "excludedDataNodesDetails";
String EXCLUDE_DATA_NODES_DETAILS_DESC = "Excluded DataNodes info";
}
10 changes: 9 additions & 1 deletion ...pat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,8 @@ public void getMetrics(MetricsCollector metricsCollector, boolean all) {

// rsWrap can be null because this function is called inside of init.
if (rsWrap != null) {
addGaugesToMetricsRecordBuilder(mrb)
MetricsRecordBuilder metricsRecordBuilder = addGaugesToMetricsRecordBuilder(mrb);
metricsRecordBuilder
.addCounter(Interns.info(TOTAL_REQUEST_COUNT, TOTAL_REQUEST_COUNT_DESC),
rsWrap.getTotalRequestCount())
.addCounter(
Expand Down Expand Up @@ -496,10 +497,17 @@ public void getMetrics(MetricsCollector metricsCollector, boolean all) {
rsWrap.getHedgedReadOpsInCurThread())
.addCounter(Interns.info(BLOCKED_REQUESTS_COUNT, BLOCKED_REQUESTS_COUNT_DESC),
rsWrap.getBlockedRequestsCount())
.addCounter(Interns.info(EXCLUDE_DATA_NODES_COUNT, EXCLUDE_DATA_NODES_COUNT_DESC),
rsWrap.getWALExcludeDNs().size())
.tag(Interns.info(ZOOKEEPER_QUORUM_NAME, ZOOKEEPER_QUORUM_DESC),
rsWrap.getZookeeperQuorum())
.tag(Interns.info(SERVER_NAME_NAME, SERVER_NAME_DESC), rsWrap.getServerName())
.tag(Interns.info(CLUSTER_ID_NAME, CLUSTER_ID_DESC), rsWrap.getClusterId());
if (!rsWrap.getWALExcludeDNs().isEmpty()) {
metricsRecordBuilder.tag(
Interns.info(EXCLUDE_DATA_NODES_DETAILS, EXCLUDE_DATA_NODES_DETAILS_DESC),
rsWrap.getWALExcludeDNs().toString());
}
}

metricsRegistry.snapshot(mrb, all);
Expand Down