-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29579: AssignmentManager is trying to pick up the other cluster's meta table after HbckChore run #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add unit tests to TestFSUtils
and TestFSTableDescriptors
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need a new test file, because the new tests could be added to existing test files. I'm not sure though, please take a look.
hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestFsClusterFiltering.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/fs/TestFsClusterFiltering.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4d9c2b2
to
c63d7d4
Compare
This comment has been minimized.
This comment has been minimized.
…'s meta table after HbckChore run
c63d7d4
to
75956d4
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New additions LGTM
Merged. Thanks @Kota-SH ! |
Jira: https://issues.apache.org/jira/browse/HBASE-29579