[SYSTEMML-625] Handle circular import references #126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates parser component to allow scripts to run in cases where circular source references exist. Previously, a circular import (e.g., a script sources itself) would result in stack overflow error where
DMLParserWrapper.doParse and DMLSyntacticValidator.exitImportStatement infinitely loop during ParseTreeWalker.walk. Test scripts are included for both DML and PyDML to exercise various forms of circular dependencies.