Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16475: add more tests to TopicImageNodeTest #15735

Merged
merged 2 commits into from Apr 30, 2024
Merged

KAFKA-16475: add more tests to TopicImageNodeTest #15735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142d4fd
add TopicImageNodeTest.java
mannoopj Apr 16, 2024
8f352ab
remove unused imports
mannoopj Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 38 additions & 5 deletions metadata/src/test/java/org/apache/kafka/image/node/TopicImageNodeTest.java
View file
Open in desktop
Expand Up @@ -17,26 +17,39 @@

package org.apache.kafka.image.node;

import org.apache.kafka.common.DirectoryId;
import org.apache.kafka.common.Uuid;
import org.apache.kafka.image.TopicImage;
import org.apache.kafka.image.node.printer.NodeStringifier;
import org.apache.kafka.metadata.LeaderRecoveryState;
import org.apache.kafka.metadata.PartitionRegistration;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;

import java.util.Arrays;
import java.util.Collections;

import java.util.HashMap;
import java.util.Map;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;


@Timeout(value = 40)
public class TopicImageNodeTest {
private final static TopicImageNode NODE = new TopicImageNode(new TopicImage("topic-image-node-test-topic", Uuid.ZERO_UUID, Collections.emptyMap()));
private final static TopicImageNode NODE = new TopicImageNode(newTopicImage("topic-image-node-test-topic", Uuid.ZERO_UUID, new PartitionRegistration.Builder().setReplicas(new int[] {2, 3, 4}).
setDirectories(DirectoryId.migratingArray(3)).
setIsr(new int[] {2, 3}).setLeader(2).setLeaderRecoveryState(LeaderRecoveryState.RECOVERED).setLeaderEpoch(1).setPartitionEpoch(345).build()));

private static TopicImage newTopicImage(String name, Uuid id, PartitionRegistration... partitions) {
Map<Integer, PartitionRegistration> partitionMap = new HashMap<>();
int i = 0;
for (PartitionRegistration partition : partitions) {
partitionMap.put(i++, partition);
}
return new TopicImage(name, id, partitionMap);
}
@Test
public void testChildNames() {
assertEquals(Arrays.asList("name", "id"), NODE.childNames());
assertEquals(Arrays.asList("name", "id", "0"), NODE.childNames());
}

@Test
Expand All @@ -57,4 +70,24 @@ public void testIdChild() {
public void testUnknownChild() {
assertNull(NODE.child("unknown"));
}

@Test
public void testChildPartitionId() {
MetadataNode child = NODE.child("0");
assertNotNull(child);
NodeStringifier stringifier = new NodeStringifier();
child.print(stringifier);
assertEquals("PartitionRegistration(replicas=[2, 3, 4], " +
"directories=[AAAAAAAAAAAAAAAAAAAAAA, AAAAAAAAAAAAAAAAAAAAAA, AAAAAAAAAAAAAAAAAAAAAA], " +
"isr=[2, 3], removingReplicas=[], addingReplicas=[], elr=[], lastKnownElr=[], leader=2, " +
"leaderRecoveryState=RECOVERED, leaderEpoch=1, partitionEpoch=345)", stringifier.toString());
}

@Test
public void testChildPartitionIdNull() {
MetadataNode child1 = NODE.child("1");
MetadataNode child2 = NODE.child("a");
assertNull(child1);
assertNull(child2);
}
}