MINOR: fix incorrect offset reset logging #20558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue was introduced with 6cdb8c3 in AK 4.0.0 release. We should cherry-pick the fix accordingly. |
chia7712
reviewed
Sep 19, 2025
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
Show resolved
Hide resolved
lucasbru
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Haha, I had the same PR locally.
Can I hijack this PR for a different change? We don't seem to log at all when we receive a InvalidOffsetException from Consumer.poll - so it's not clear where we call this function from the logs. So I would like to have a
} catch (final InvalidOffsetException e) {
log.info("Found no valid offset for {} partitions, resetting.", e.partitions().size());
resetOffsets(e.partitions(), e);
}
in StreamThread.pollRequests. Maybe you can add this here, otherwise I will push a separate PR
chia7712
approved these changes
Sep 19, 2025
mjsax
added a commit
that referenced
this pull request
Sep 22, 2025
We need to only pass in the reset strategy, as the `logMessage` parameter was removed. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Lucas Brutschy <lbrutschy@confluent.io>
|
Thanks for merging Lucas. -- Also cherry-picked to @clolov -- if you do a new RC for 4.0.1, and feel like it, might also be nice to cherry-pick to |
jim0987795064
pushed a commit
to jim0987795064/kafka
that referenced
this pull request
Sep 25, 2025
We need to only pass in the reset strategy, as the `logMessage` parameter was removed. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Lucas Brutschy <lbrutschy@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to only pass in the reset strategy, as the
logMessageparameter was removed.
Reviewers: Chia-Ping Tsai chia7712@gmail.com, Lucas Brutschy
lbrutschy@confluent.io