Skip to content

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Oct 2, 2025

tools-api is already in core module runtime path, so adding it to
releaseTarGz causes the resolution conflicts, which will be a fatal
error in gradle 9

Reviewers: Ken Huang s7133700@gmail.com, TengYao Chi
frankvicky@apache.org, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Oct 2, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandboat Could you please run releaseTarGz locally to ensure the libs are exactly the same?

@brandboat
Copy link
Member Author

brandboat commented Oct 2, 2025

@chia7712 , below are steps to verify the release tarball have no changes after this patch.

Note: I test these cmds in my mac environment

git checkout trunk
./gradlew clean releaseTarGz
cd core/build/distributions/
tar -xvf kafka_2.13-4.2.0-SNAPSHOT.tgz
rm kafka_2.13-4.2.0-SNAPSHOT.tgz
cd kafka_2.13-4.2.0-SNAPSHOT/site-docs
tar -xvf kafka_2.13-4.2.0-SNAPSHOT-site-docs.tgz
rm kafka_2.13-4.2.0-SNAPSHOT-site-docs.tgz
cd ../
find . -type f -exec stat -f "%z %N" {} \; > ~/Downloads/trunk

checkout to KAFKA-19750 branch

./gradlew clean releaseTarGz
cd core/build/distributions/
tar -xvf kafka_2.13-4.2.0-SNAPSHOT.tgz
rm kafka_2.13-4.2.0-SNAPSHOT.tgz
cd kafka_2.13-4.2.0-SNAPSHOT/site-docs
tar -xvf kafka_2.13-4.2.0-SNAPSHOT-site-docs.tgz
rm kafka_2.13-4.2.0-SNAPSHOT-site-docs.tgz
cd ../
find . -type f -exec stat -f "%z %N" {} \; > ~/Downloads/KAFKA-19750

diff ~/Downloads/KAFKA-19750 ~/Downloads/trunk show no output, these two files content are the same.

Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the output. LGTM
image

Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the changes using diff ~/Downloads/KAFKA-19750 ~/Downloads/trunk, and the output is as expected.

@chia7712
Copy link
Member

chia7712 commented Oct 4, 2025

the failed tests are known flaky

@chia7712 chia7712 merged commit bc2f23b into apache:trunk Oct 4, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants