Skip to content

MINOR: Move ChannelState.exception() to its own class #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MINOR: Move ChannelState.exception() to its own class #3945

wants to merge 1 commit into from

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Sep 22, 2017 •
edited
Loading

Given that Java doesn't support pattern matching, the benefit
is not as clear.

Also:

  • Renamed state to value to avoid method calls like state.state
  • Implemented ChannelState.toString
  • Removed some unused imports.

@ijuma
MINOR: Move ChannelState.exception() to its own class
accbbbf 
Given that Java doesn't support pattern matching, the benefit
is not as clear.

Also implemented ChannelState.toString and removed some
unused imports.
@ijuma ijuma force-pushed the improve-channel-state-structure branch from 78a04b1 to accbbbf Compare September 22, 2017 09:37
@ijuma ijuma requested a review from rajinisivaram January 3, 2018 19:42
rajinisivaram
rajinisivaram reviewed Jan 8, 2018
View reviewed changes
Copy link
Contributor

@rajinisivaram rajinisivaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijuma Thanks for the PR, the changes look good. The PR has conflicts and needs rebasing though.

@github-actions GitHub Actions
Copy link

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Nov 15, 2024
@github-actions github-actions bot closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajinisivaram rajinisivaram rajinisivaram left review comments

Assignees
No one assigned
Labels
closed-stale PRs that were closed due to inactivity stale Stale PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijuma @rajinisivaram