Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6605 fix NPE in Flatten when optional Struct is null #5705

Merged
merged 1 commit into from
Jul 12, 2019
Merged

KAFKA-6605 fix NPE in Flatten when optional Struct is null #5705

merged 1 commit into from
Jul 12, 2019

Conversation

mihbor
Copy link
Contributor

@mihbor mihbor commented Sep 27, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mihbor
Copy link
Contributor Author

mihbor commented Oct 1, 2018

Hi @wicknicks , would you kindly be able to review this PR as well please?

@wicknicks
Copy link
Contributor

@mihbor could you please update the description with a few more details. Particularly, the record/schema that caused the exception, and the inputs used to configure the transformation. thanks!

rayokota
rayokota approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayokota
Copy link
Contributor

@rhauch , can you merge this if it looks ok?

rhauch
rhauch approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mihbor!

@rhauch rhauch merged commit fc4fea6 into apache:trunk Jul 12, 2019
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
2400f72 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
1fa3e97 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
c651486 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
842dacd 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
@rhauch rhauch mentioned this pull request Jul 12, 2019
Closed
3 tasks
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
d78fe37 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
rhauch pushed a commit that referenced this pull request Jul 12, 2019
@mihbor @rhauch
KAFKA-6605: Fix NPE in Flatten when optional Struct is null (#5705)
c6ffe50 
Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
@HungUnicorn
Copy link

HungUnicorn commented Jul 15, 2019 •
edited
Loading

The jira ticket says it works from 2.3.1? is the timeline of 2.3.1 already planned?
https://issues.apache.org/jira/browse/KAFKA-6605

@wicknicks
Copy link
Contributor

@HungUnicorn doesn't look like there is a plan yet. Watch this page for updates: https://cwiki.apache.org/confluence/display/KAFKA/Future+release+plan

ijuma added a commit to confluentinc/kafka that referenced this pull request Jul 20, 2019
@ijuma
Merge remote-tracking branch 'apache-github/2.3' into ccs-2.3
90e4b24 
* apache-github/2.3:
  MINOR: Update documentation for enabling optimizations (apache#7099)
  MINOR: Remove stale streams producer retry default docs. (apache#6844)
  KAFKA-8635; Skip client poll in Sender loop when no request is sent (apache#7085)
  KAFKA-8615: Change to track partition time breaks TimestampExtractor (apache#7054)
  KAFKA-8670; Fix exception for kafka-topics.sh --describe without --topic mentioned (apache#7094)
  KAFKA-8602: Separate PR for 2.3 branch (apache#7092)
  KAFKA-8530; Check for topic authorization errors in OffsetFetch response (apache#6928)
  KAFKA-8662; Fix producer metadata error handling and consumer manual assignment (apache#7086)
  KAFKA-8637: WriteBatch objects leak off-heap memory (apache#7050)
  KAFKA-8620: fix NPE due to race condition during shutdown while rebalancing (apache#7021)
  HOT FIX: close RocksDB objects in correct order (apache#7076)
  KAFKA-7157: Fix handling of nulls in TimestampConverter (apache#7070)
  KAFKA-6605: Fix NPE in Flatten when optional Struct is null (apache#5705)
  Fixes apache#8198 KStreams testing docs use non-existent method pipe (apache#6678)
  KAFKA-5998: fix checkpointableOffsets handling (apache#7030)
  KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup v0 (apache#7072)
  KAFKA-8591; WorkerConfigTransformer NPE on connector configuration reloading (apache#6991)
  MINOR: add upgrade text (apache#7013)
  Bump version to 2.3.1-SNAPSHOT
xiowu0 pushed a commit to linkedin/kafka that referenced this pull request Aug 22, 2019
@mihbor @xiowu0
[LI-CHERRY-PICK] [2400f72] KAFKA-6605: Fix NPE in Flatten when option…
1bbcfbe 
…al Struct is null (apache#5705)

TICKET = KAFKA-6605
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [2400f72]
ORIGINAL_DESCRIPTION =

Correct the Flatten SMT to properly handle null key or value `Struct` instances.

Author: Michal Borowiecki <michal.borowiecki@openbet.com>
Reviewers: Arjun Satish <arjun@confluent.io>, Robert Yokota <rayokota@gmail.com>, Randall Hauch <rhauch@gmail.com>
(cherry picked from commit 2400f72)
@HungUnicorn HungUnicorn mentioned this pull request Dec 18, 2019
Closed
@gharris1727 gharris1727 mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhauch rhauch rhauch approved these changes

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mihbor @wicknicks @rayokota @HungUnicorn @rhauch