SOLR-13665: Added missing netty dependencies to solrJ #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ClassNotFound error when attempting SSL connection with the new Zookeeper 3.5.5.
Solution
Added missing netty dependencies to solrJ and upgraded netty to v 4.1.29.Final which is the version ZK uses.
See also https://issues.apache.org/jira/browse/ZOOKEEPER-3494. Probably the new Solr gradle build will "just work" from ZK 3.5.6 and later (for 3.5.5 we'd pull in netty-all which is unnecessarily large).
Tests
Hard to test since we do not have any ZK SSL tests in the code base
Checklist
Please review the following and check all that apply:
master
branch.ant precommit
and the appropriate test suite.