LUCENE-10368: Mark IntTaxonomyFacets as deprecated #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gsmiller
force-pushed
the
LUCENE-10368-reduce-vis-taxo-facet-on9
branch
from
88a90f7 to
b13f7b9
Compare
gf2121
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IntTaxonomyFacets is intended as an internal implementation detail but has public visibility, so could also be serving as an extension point for user-created faceting implementations. We want to migrate this to pkg-private. The first step is marking it
deprecatedin 9.x.Solution
Add
@Deprecatedtag and javadoc.Tests
N/A
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.