Skip to content

LUCENE-10368: Mark IntTaxonomyFacets as deprecated #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022
Merged

LUCENE-10368: Mark IntTaxonomyFacets as deprecated #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b13f7b9
LUCENE-10368: Mark IntTaxonomyFacets as deprecated
gsmiller Jan 12, 2022
adce1dc
Merge branch 'branch_9x' into LUCENE-10368-reduce-vis-taxo-facet-on9
gsmiller Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ API Changes

* LUCENE-10381: Require users to provide FacetsConfig for SSDV faceting. (Greg Miller)

* LUCENE-10368: IntTaxonomyFacets has been deprecated and is no longer a supported extension point
for user-created faceting implementations. (Greg Miller)

New Features
---------------------

Expand Down
11 changes: 10 additions & 1 deletion lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,16 @@
import org.apache.lucene.facet.LabelAndValue;
import org.apache.lucene.facet.TopOrdAndIntQueue;

/** Base class for all taxonomy-based facets that aggregate to a per-ords int[]. */
/**
* Base class for all taxonomy-based facets that aggregate to a per-ords int[].
*
* @deprecated Visibility of this class will be reduced to pkg-private in a future version. This
* class is meant to host common code as an internal implementation detail to {@link
* FastTaxonomyFacetCounts} and {@link TaxonomyFacetSumIntAssociations},and is not intended as
* an extension point for user-created {@code Facets} implementations. If your code is relying
* on this, please migrate necessary functionality down into your own class.
*/
@Deprecated
public abstract class IntTaxonomyFacets extends TaxonomyFacets {

/**
Expand Down