[MDEP-644] Add tgf, dot, graphml support for verboseGraphSerializer #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please change the title so it differs from #92 |
ian-lavallee
changed the title
elharo
reviewed
Aug 14, 2020
ghost
approved these changes
Aug 14, 2020
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Aug 14, 2020
| Map<DependencyNode, String> nodeErrors = getNodeConflictMessagesBfs( root, coordinateStrings, | ||
| coordinateVersionMap ); | ||
|
|
||
| if ( "graphml".equals( outputType ) ) |
There was a problem hiding this comment.
This long chain of if's makes me wonder if what we really need is a base abstract Serializer type and subclasses for each type.
There was a problem hiding this comment.
Just committed that
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializer.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/maven/plugins/dependency/tree/VerboseGraphSerializerTest.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Aug 14, 2020
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseDependencyGraphBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphGraphmlSerializer.java
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/tree/VerboseGraphGraphmlSerializer.java
Show resolved
Hide resolved
elharo
approved these changes
Aug 17, 2020
cosmin
pushed a commit
to cosmin/maven-dependency-plugin
that referenced
this pull request
Nov 24, 2020
…pache#95) Add tgf, dot, graphml support for verboseGraphSerializer
|
Resolve #1078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DOT, TGF, and GraphML support for the verbose serializer