Skip to content

Conversation

belingueres
Copy link
Contributor

Added the funcionality.
No added ITs, instead tested the maven-enforcer-plugin with this version
of m-dependency-tree. Tested and passed all tests with: Maven 3.0.4,
3.0.5, 3.1.0, 3.5.4, 3.6.0. Didn't work with Maven 3.0.0 (sonatype
aether 1.7). Other Maven versions not tested.

Added the funcionality.
No added ITs, instead tested the maven-enforcer-plugin with this version
of m-dependency-tree. Tested and passed all tests with: Maven 3.0.4,
3.0.5, 3.1.0, 3.5.4, 3.6.0. Didn't work with Maven 3.0.0 (sonatype
aether 1.7). Other Maven versions not tested.
@rfscholte
Copy link
Contributor

What you probably want to do is adding maven-artifact-transfer as dependency to this project and use those methods.

filtering of the dependencies.

Specially for Maven 3.0, I couldn't get the desired behavior using the
provided DependencyGraphTransformer, DependencySelector, etc. so I
copied those implementation from Eclipse aether to work on Sonatype
aether classes. As a result it is expected to get the same output than
Maven 3.1+ (though it will probably need more testing (just tested with
enforcer plugin's DependencyConvergence and RequireUpperBoundDeps ITs).
@slachiewicz
Copy link
Member

We should no longer use maven-artifact-transfer

@rfscholte
Copy link
Contributor

merged with 7e225ab

@rfscholte rfscholte closed this May 22, 2021
@cstamas
Copy link
Member

cstamas commented May 22, 2021

I don't quite understand why this was merged as is...

  • Uses plexus
  • Uses AbstractLogEnabled
  • Uses nasty reflection pattern from m-artifact-transfer we want to get rid

?

@rfscholte
Copy link
Contributor

I'll leave the clean up to somebody else on a separate ticket.

@belingueres
Copy link
Contributor Author

I'm glad this is finally moving forward. Let me know if you need further assistance.

@rfscholte
Copy link
Contributor

@belingueres I've tried to restore all integration-tests, and it seems like the verbose output is less compared the 2.x
I've created the branch https://github.com/apache/maven-dependency-tree/tree/fix-tests , which in still work in progress, but you should be able to see the differences.
I could use an extra set of hands or eyes to get the verbose information complete.

@belingueres
Copy link
Contributor Author

@rfscholte I'll take a look in these days.

@jira-importer
Copy link

Resolve #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants