Skip to content

Conversation

Donny9
Copy link
Contributor

@Donny9 Donny9 commented May 17, 2024

Summary

this patch #2394 enable vfork test, but vfork test is failed in sim:citest so, let's recover this patch after fix crash.

Impact

fix ci break

Testing

local test

This reverts commit 2ce6be6.
this patch enable vfork test, but vfork test is failed in sim:citest
so, let's recover this patch after fix crash.
@Donny9
Copy link
Contributor Author

Donny9 commented May 17, 2024

@SPRESENSE
Copy link
Contributor

@Donny9
CONFIG_ARCH_HAVE_VFORK is not defined anywhere.
I think it would be better to remove the select for CONFIG_ARCH_HAVE_FORK from CONFIG_ARCH_SIM to avoid sim:citest failure so that other architectures are not affected.

@xiaoxiang781216
Copy link
Contributor

@Donny9 CONFIG_ARCH_HAVE_VFORK is not defined anywhere. I think it would be better to remove the select for CONFIG_ARCH_HAVE_FORK from CONFIG_ARCH_SIM to avoid sim:citest failure so that other architectures are not affected.

good suggestion. @Donny9 let's disable fork test on sim util the problem gets fixed.

@Donny9
Copy link
Contributor Author

Donny9 commented May 20, 2024

@SPRESENSE @xiaoxiang781216 okay,new patch:apache/nuttx#12375 on nuttx/

@Donny9 Donny9 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants