Skip to content
Discussion options

You must be logged in to vote

Thanks for the detailed report. You're right, this is a bug, and it is still present on the latest main (apache/skywalking-go@7c664b5). I reproduced it the same way: a valid sw8 header plus NewConstSampler(false) on the downstream side gives a NoopSpan, and nothing is reported.

1. Is inheriting the upstream sampling decision intended?

Yes. When the entry has a valid upstream context, the trace must be force-sampled and the local sampler must not run. That is what isForceSample in createSpan0 is for, and it matches the Java agent: ContextManager#createEntrySpan force-samples whenever carrier.isValid().

2. Should coreOpts be applied before isForceSample is evaluated?

Yes. When the plugin AP…

Replies: 1 comment 4 replies

Comment options

You must be logged in to vote
4 replies
@wu-sheng
Comment options

wu-sheng Nov 6, 2026
Collaborator

@wu-sheng
Comment options

wu-sheng Nov 7, 2026
Collaborator

@wu-sheng
Comment options

wu-sheng Nov 7, 2026
Collaborator

@blanche789
Comment options

Answer selected by blanche789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants