Skip to content
Discussion options

You must be logged in to vote

Thanks for raising this. It is a bug, not just a missing option. With multiple headers, the command-line paths replaced every header's paths, so each file was checked against every header. header check could never pass, and header fix inserted all the headers into every file.

apache/skywalking-eyes#298 makes the behavior you proposed the default, with no new flag:

CLI-selected files ∩ header_X.paths − header_X.paths-ignore

A header counts the selected files that its paths don't cover as ignored, the same as a run without command-line paths. With a single header and the default paths: ['**'], nothing changes.

One note for multi-license configs: a file that the paths of several headers cov…

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@jdumas
Comment options

Answer selected by wu-sheng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants