Skip to content

SOLR-15527: Security admin screen for managing users, roles, and permissions #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2021
Merged

SOLR-15527: Security admin screen for managing users, roles, and permissions #209

merged 4 commits into from
Jul 30, 2021

Conversation

thelabdude
Copy link
Contributor

@thelabdude thelabdude commented Jul 9, 2021 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-15527

Description

Add new security panel to admin UI

Solution

See screenshots in JIRA

Tests

Manual tests in browser

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@thelabdude thelabdude marked this pull request as draft July 9, 2021 20:25
@thelabdude thelabdude force-pushed the security-ui branch 2 times, most recently from 4a63d92 to ee877fd Compare July 13, 2021 22:27
@thelabdude thelabdude force-pushed the security-ui branch 2 times, most recently from 5bda327 to c23268f Compare July 26, 2021 19:12
@thelabdude thelabdude marked this pull request as ready for review July 26, 2021 19:38
@thelabdude thelabdude requested a review from ctargett July 28, 2021 20:32
ctargett
ctargett requested changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ctargett ctargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one place I think you maybe want to link to the bin/solr auth docs.

solr/solr-ref-guide/src/security-ui.adoc Outdated

image::images/security-ui/security-not-enabled-warn.png[image,width=500]

When first getting started with Solr, use the `bin/solr auth` command-line utility to enable security for your Solr installation (cloud mode only).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to solr-control-script-reference.adoc#authentication here (or somewhere in this section) so people can get the details on all the params if they need them?

@thelabdude thelabdude merged commit 2458360 into apache:main Jul 30, 2021
@thelabdude thelabdude mentioned this pull request Jul 30, 2021
Merged
epugh pushed a commit to epugh/solr that referenced this pull request Oct 22, 2021
@thelabdude
SOLR-15527: Security admin screen for managing users, roles, and perm…
8bdae5c 
…issions (apache#209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctargett ctargett ctargett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelabdude @ctargett