Test: UpdateRequestProcessorFactoryTest, can be flaky #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els (without restoring)
|
Includes removal of |
colvinco
pushed a commit
to colvinco/solr
that referenced
this pull request
Apr 4, 2025
Don't call S3MockRule.builder().silent() since it manipulates log levels (without restoring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(already reviewed by a colleague & contributor @pmcarthur-apache )
I'm nearly sure that
S3MockRule.builder().silent()will change the root logger to WARN. Maybe for JUL; not sure if such a change federates to Log4j2. Maybe we should remove silent() but I didn't check how bad/verbose it is.