SOLR-17864: Flip solr.hideStackTrace to .enabled equivalent. #3503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tricky one because I didn't want to change the solr.xml name AS well, so now in solr.xml we have solr.hideStackTrace, but system is solr.responses.stacktrace.enabled. Why is this in solr.xml?
dsmiley
reviewed
Aug 23, 2025
| private List<String> allowUrls = Collections.emptyList(); | ||
| private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace"); | ||
| private boolean hideStackTrace = | ||
| !(Boolean.parseBoolean(System.getProperty("solr.responses.stacktrace.enabled", "true"))); |
| solr.enable.stream.body=solr.requests.streaming.body.enabled | ||
| solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled | ||
| solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types | ||
| solr.hide.stack.trace=solr.responses.stacktrace.enabled |
There was a problem hiding this comment.
it'd be neat if there was a way to reflect that we inverted a boolean. Like use an exclamation in the beginning.
There was a problem hiding this comment.
Not a bad idea.. Maybe if the line starts with a ! then you know while processing that it's an inversion. That would simplify the rule logic in EnvUtils.java.. This is a great idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tricky one because I didn't want to change the solr.xml name AS well, so now in solr.xml we have solr.hideStackTrace, but system is solr.responses.stacktrace.enabled.
Why is this in solr.xml?
https://issues.apache.org/jira/browse/SOLR-17864
I am going to leave this one for just this one, unless I find other solr.xml that are also system variable equivalents.. Then maybe this grows into a whole "why do we define these in solr.xml and in system variables?" disucssion!