Skip to content

Conversation

HoustonPutman
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17893

  • Both clusterState.getCollectionOrNull() calls in HttpSolrCall should allow for cached values. There's no reason to fetch live versions every time here.
  • The lastUpdateTime needs to be updated after getting the stats. If there is no change, that is an "update". We don't want to check every call after 2 seconds, if the ClusterState hasn't changed. We want to check once every 2 seconds.

Copy link
Contributor

@dsmiley dsmiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I remember looking at this many months ago, thinking along the lines of what you did but took no action. I wasn't looking at it in the context of a perf problem to solve, so I let it be.

@HoustonPutman HoustonPutman merged commit fda4c40 into apache:main Sep 5, 2025
3 checks passed
@HoustonPutman HoustonPutman deleted the fix-remote-query branch September 5, 2025 19:36
HoustonPutman added a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants