SOLR-17926: Add tracking of time already spent to discount the limit for sub-requests #3691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Fix a couple NPEs due to missing result Ids or docs when all shards are skipped.
hossman
reviewed
Sep 26, 2025
| // Skip this shard since one or more limits will be tripped | ||
| if (log.isDebugEnabled()) { | ||
| log.debug("Skipping request to shard '{}' due to query limits, params {}", shard, params); | ||
| log.info("Skipping request to shard '{}' due to query limits, params {}", shard, params); |
There was a problem hiding this comment.
missmatch between log.isDebugEnabled and log.info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is inspired by the idea described by @gus-asf:
timeAllowed, and further decrease it by an approximate flight time (configurable)