Skip to content

SOLR-16213 Upgrade Jackson to 2.13.3 #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2022
Merged

SOLR-16213 Upgrade Jackson to 2.13.3 #877

merged 2 commits into from
May 30, 2022

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented May 24, 2022

@janhoy janhoy requested review from madrob and risdenk May 24, 2022 20:37
@janhoy
Copy link
Contributor Author

janhoy commented May 25, 2022

Not sure I understand why precommit fails here

[21:05:39.470] FATAL (antora): problem encountered while reading ui.supplemental_files: ENOENT: no such file or directory, access '/home/runner/work/solr/solr/.gradle/node/solr-ref-guide/node_modules/@antora/lunr-extension/supplemental_ui'

Wonder if that is some stale builder cache issue, seems unrelated.

@HoustonPutman
Copy link
Contributor

Not sure I understand why precommit fails here

[21:05:39.470] FATAL (antora): problem encountered while reading ui.supplemental_files: ENOENT: no such file or directory, access '/home/runner/work/solr/solr/.gradle/node/solr-ref-guide/node_modules/@antora/lunr-extension/supplemental_ui'

Wonder if that is some stale builder cache issue, seems unrelated.

It looks like the upstream antora-lunr-extension changed it's download path in the node modules? Will make a fix soon

@HoustonPutman
Copy link
Contributor

Ahh ok it's here. Just making our lives easier 🙂

https://gitlab.com/antora/antora-lunr-extension/-/issues/15

@risdenk
Copy link
Contributor

risdenk commented May 26, 2022

@janhoy I pushed the merging to main to get precommit fixes from Houston.

@janhoy janhoy merged commit e88cd0f into apache:main May 30, 2022
@janhoy janhoy deleted the solr16213-jackson-upgrade branch May 30, 2022 09:44
janhoy added a commit that referenced this pull request May 30, 2022
@janhoy @risdenk
SOLR-16213 Upgrade Jackson to 2.13.3 (#877)
0194f28 
Co-authored-by: Kevin Risden <krisden@apache.org>
(cherry picked from commit e88cd0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risdenk risdenk risdenk approved these changes

@madrob madrob Awaiting requested review from madrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhoy @HoustonPutman @risdenk