supersetEmbeddedSdk filters.visible = false doesn't seem to work

[mike-pt]

A clear and concise description of what the bug is.

How to reproduce the bug

            dashboardUiConfig: { hideTitle: true, hideChartControls: true,
                filters: {
                    visible: false
                }
            }, 

Expected results

filter sidebar show not be visible

Actual results

filter sidebar is still visible, expanded: false does work though so it seems to be only visible that doesn't take efect.

Screenshots

Environment

(please complete the following information):

• browser type and version:
  Firefox 113 and Safari 16.4 both on macos

Using docker apache/superset:latest build yesterday

• any feature flags active:

FEATURE_FLAGS = {
    "ALERT_REPORTS": True,
    "ENABLE_TEMPLATE_PROCESSING": True,
    "DASHBOARD_RBAC": True,
    "EMBEDDED_SUPERSET": True,
    "DASHBOARD_CROSS_FILTERS": True,
    "SQL_VALIDATORS_BY_ENGINE": True
}

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[matheusbsilva]

I'm facing the same issue here.

[rusackas]

Is there documentation somewhere that claims this works? I don't think this feature exists, so I'm hesitant to say this is a bug. This is probably a feature request, unless I'm missing something?

[mc-zact]

Apparently, it used to be a feature, but it was deprecated, at least, that was what I was told in a preset call about how to embed dashboards.

Superset doesn't have docs about how to handle this in CSS either but preset does
.. however, the ccs I'd they mention don't match... I found the correct one, though.

But it's not a very clean way to do this, we need to apply thar CSS to every dashboard.. filters become hidden in the main web UI to not just embedding, it also doesn't really remove them... just sets a display:none... but they are still there in the html/dom....

I guess the current implementation is not ideal, feel free to mark this a FR if you think its not a bug but there were other folks on slack also asking about this so it does seem like it was supported at some point in the SDK.

[matheusbsilva]

@rusackas On the SDK docs there is an example showing that there is an option to hide filters using the filters.visible parameter:

superset/superset-embedded-sdk/README.md

Lines 43 to 47 in 62b4564

	dashboardUiConfig: { // dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded (optional)
	hideTitle: true,
	filters: {
	expanded: true,
	}

[rusackas]

@rusackas On the SDK docs there is an example showing that there is an option to hide filters using the filters.visible parameter:

superset/superset-embedded-sdk/README.md

Lines 43 to 47 in 62b4564

	dashboardUiConfig: { // dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded (optional)
	hideTitle: true,
	filters: {
	expanded: true,
	}

Hmm.... the docs say "expanded" not "visible" - that would make a difference.

Even then, I think that just sets the bar to collapsed rather than expanded. It's not gone just closed.

[mike-pt]

Maybe this helps: eb80568 ``` /** The dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded **/ ``` <--- which no longer seems to be the case... there's also several posts in slack about this... and even examples posted on how to hide filters... Maybe that was always buggy and got removed... that much I don't know because the release notes unfortunately don't mention this and I was lazy to dig into more code or PRs etc Anyway the fact is there is a lot of evidence to suggest this was indeed a thing, and it no longer is, so if you want to set this as FR instead of BUG I think it's fine, but it's definitely much needed, there's more than one thread on slack, I just decided to bring it over Github because it seemed like the correct approach perhaps it wasn't

[herrlegno]

It was indeed a feature, i was relying on it. After updating superset today, I got this issue.

[matheusbsilva]

@herrlegno which version of superset you were using before the update?

[herrlegno]

@matheusbsilva I can't tell you for sure, because I cloned the repo not from dockerhub. I think it was 2.1.0rc1 because the reason for updating was the screenshot generation was broken. I hope this is helpful enough.

[matheusbsilva]

Digging into the commits history I found the one that added this feature: b7ecb14. And apparently the option was removed here: 5f0c320, not sure why. It would be great if @john-bodley could give us more context on why this option was removed because It is a great feature to have, maybe we can find a way to add it again.

[john-bodley]

@matheusbsilva reading through #23228 it was likely removing show_filters was a mistake, i.e., I probably mistook it for show_native_filters.

[sebastiankruk]

Do we know what this bus is going to be fixed?

[markhc]

Any updates on this?

[aerodinesh]

This was a very good feature, can we please add it back as were before. Thanks.

[tanmaykansara]

was this issue merged for 3.1.0 ?

[rusackas]

was this issue merged for 3.1.0 ?

3.1 was a cut from master, so I believe so.

[pritammobisoft]

I am running Superset version: 4.0.1
Still facing this issue.

dashboardUiConfig: {
          // dashboard UI config: hideTitle, hideTab, hideChartControls, filters.visible, filters.expanded (optional)
          hideTitle: true,
          filters: {
            expanded: false,
            visible: false
          },
        },

filters.expanded: false works but filters.visible: false doesn't work.

This code is taken from the README from: https://github.com/apache/superset/tree/master/superset-embedded-sdk