fix(trino): allow impersonate_user flag to be imported

[FGrobelny]

SUMMARY

impersonate_user flag allows for user impersonation when connecting to trino using kerberos. Currently it cannot be imported.

TESTING INSTRUCTIONS

1. Create trino_from_ui connection using UI, check "impersonate user" box.
2. Create trino_from_code connection file

    import_datasources.yaml: |
      databases:
      - database_name: trino_from_code
        sqlalchemy_uri: <url>
        cache_timeout: null
        expose_in_sqllab: true
        allow_run_async: true
        allow_ctas: true
        allow_cvas: true
        allow_dml: true
        allow_csv_upload: true
        impersonate_user: true
        extra: "<extra>"
        encrypted_extra: "<encrypted_extra>"

4. Import datasources using superset import_datasources -p import_datasources.yaml
5. Check in database if impersonate_user = "t" in "dbs" table for both connections.

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[john-bodley]

Thanks @FGrobelny for the PR. I have one small formatting suggestion (which should be identified via CI—given that I now enabled the running of the tasks). I've also CC'ed a few more reviewers.

[NickLarsenNZ]

@FGrobelny, just wanted to clarify if this should work for importing a Zip via the api (POST /api/v1/assets/import)?

I am getting the following error (in superset 3.0.1):

{
  "errors": [
    {
      "message": "Error importing assets",
      "error_type": "GENERIC_COMMAND_ERROR",
      "level": "warning",
      "extra": {
        "databases/Trino_tpch.yaml": {
          "impersonate_user": [
            "Unknown field."
          ]
        },
        "issue_codes": [
          {
            "code": 1010,
            "message": "Issue 1010 - Superset encountered an error while running a command."
          }
        ]
      }
    }
  ]
}

I have no other assets, just this connection:

database_name: Trino tpch
sqlalchemy_uri: trino://superset:XXXXXXXXXX@trino:8443/tpch?verify=false
cache_timeout: null
expose_in_sqllab: true
allow_run_async: false
allow_ctas: false
allow_cvas: false
allow_dml: false
allow_csv_upload: false
impersonate_user: true # here's what I added, and no the import breaks
extra:
  allows_virtual_table_explore: true
uuid: 82944780-fbb2-45a9-9450-f1e730a2915b
version: 1.0.0

If I create the connection manually and export it, it doesn't contain impersonate_user: true.

[FGrobelny]

Hi! Please try 3.0.2 version :) https://github.com/apache/superset/blob/master/CHANGELOG.md#302-mon-nov-20-073838-2023--0500