fix(chore): dashboard requests to database equal the number of slices it has #24709

Always-prog · 2023-07-16T08:36:07Z

SUMMARY

Hello!
Superset 2.1.0 has an issue where the requests made when getting a dashboard repeat the same number of times as the number of slices. This is a significant problem because, for example, if the dashboard size is 1MB and it contains 100 slices, each user opening this dashboard generates 100MB of requests. Considering logs, endpoint checks, etc., it can reach 500-1000MB per user!

I have fixed this issue by retrieving the dashboard using id, uuid, or slug, and checking the access using the raise_for_dashboard_access function, which verifies access to the data sources.

TESTING INSTRUCTIONS

Create a dashboard with 2 slices.
Set the sqlalchemy logs level to DEBUG.
Make a request to dashboard//charts/.
Observe that the dashboard requests are repeated for each slice.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

… it has

codecov · 2023-07-16T08:44:32Z

Codecov Report

Merging #24709 (96abf4d) into master (0328dd2) will not change coverage.
The diff coverage is n/a.

❗ Current head 96abf4d differs from pull request most recent head 219310e. Consider uploading reports for the commit 219310e to get more accurate results

@@           Coverage Diff           @@
##           master   #24709   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files        1901     1901           
  Lines       74008    74008           
  Branches     8183     8183           
=======================================
  Hits        51047    51047           
  Misses      20840    20840           
  Partials     2121     2121

Flag	Coverage Δ
hive	`54.12% <ø> (ø)`
mysql	`79.35% <ø> (ø)`
postgres	`79.44% <ø> (ø)`
presto	`54.01% <ø> (ø)`
python	`83.45% <ø> (ø)`
sqlite	`78.03% <ø> (ø)`
unit	`54.83% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/daos/dashboard.py	`96.68% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…removed joining slices

Always-prog · 2023-07-16T13:46:56Z

@dpgaspar Hi! I see you added a commit that joins slices to the dashboard query (3761694). Just wondering why it was added? I removed the join and there don't seem to be any failing test cases.

john-bodley · 2023-07-18T16:55:14Z

superset/daos/dashboard.py

@@ -63,8 +63,6 @@ def get_by_id_or_slug(cls, id_or_slug: int | str) -> Dashboard:
            query = (
                db.session.query(Dashboard)
                .filter(id_or_slug_filter(id_or_slug))
-                .outerjoin(Slice, Dashboard.slices)


@dpgaspar would you mind looking into this as it seems you added this logic in #22358? Note it's interesting that the unit/integration tests passed with the removal of these two lines.

Always-prog · 2023-08-03T11:39:33Z

@dpgaspar Hello! Can you look at the PR?

Always-prog · 2023-08-16T11:25:58Z

@john-bodley @dpgaspar Hi!
Any progress on reviewing my PR?

dpgaspar

Seems safe to remove those outerjoins, yet it's not clear to me what kind of requests are you referring to, will assume db request/queries:

Tested with /api/v1/dashboard/8/charts (using the example dashboard Sales)

With this change, generated queries:

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT slices.uuid AS slices_uuid, slices.created_on AS slices_created_on, slices.changed_on AS slices_changed_on, slices.id AS slices_id, slices.slice_name AS slices_slice_name, slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type, slices.datasource_name AS slices_datasource_name, slices.viz_type AS slices_viz_type, slices.params AS slices_params, slices.query_context AS slices_query_context, slices.description AS slices_description, slices.cache_timeout AS slices_cache_timeout, slices.perm AS slices_perm, slices.schema_perm AS slices_schema_perm, slices.last_saved_at AS slices_last_saved_at, slices.last_saved_by_fk AS slices_last_saved_by_fk, slices.certified_by AS slices_certified_by, slices.certification_details AS slices_certification_details, slices.is_managed_externally AS slices_is_managed_externally, slices.external_url AS slices_external_url, slices.created_by_fk AS slices_created_by_fk, slices.changed_by_fk AS slices_changed_by_fk
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id

SELECT tables.uuid AS tables_uuid, tables.created_on AS tables_created_on, tables.changed_on AS tables_changed_on, tables.id AS tables_id, tables.description AS tables_description, tables.default_endpoint AS tables_default_endpoint, tables.is_featured AS tables_is_featured, tables.filter_select_enabled AS tables_filter_select_enabled, tables."offset" AS tables_offset, tables.cache_timeout AS tables_cache_timeout, tables.params AS tables_params, tables.perm AS tables_perm, tables.schema_perm AS tables_schema_perm, tables.is_managed_externally AS tables_is_managed_externally, tables.external_url AS tables_external_url, tables.table_name AS tables_table_name, tables.main_dttm_col AS tables_main_dttm_col, tables.database_id AS tables_database_id, tables.fetch_values_predicate AS tables_fetch_values_predicate, tables.schema AS tables_schema, tables.sql AS tables_sql, tables.is_sqllab_view AS tables_is_sqllab_view, tables.template_params AS tables_template_params, tables.extra AS tables_extra, tables.normalize_columns AS tables_normalize_columns, tables.created_by_fk AS tables_created_by_fk, tables.changed_by_fk AS tables_changed_by_fk, anon_1.slices_datasource_id AS anon_1_slices_datasource_id, anon_1.slices_datasource_type AS anon_1_slices_datasource_type
superset_app             | FROM (SELECT DISTINCT slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id) AS anon_1 JOIN tables ON anon_1.slices_datasource_id = tables.id AND anon_1.slices_datasource_type = %(datasource_type_1)s

Before this change:

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_slices AS dashboard_slices_1 JOIN slices ON slices.id = dashboard_slices_1.slice_id) ON dashboards.id = dashboard_slices_1.dashboard_id LEFT OUTER JOIN tables ON slices.datasource_id = tables.id AND slices.datasource_type = %(datasource_type_1)s LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT slices.uuid AS slices_uuid, slices.created_on AS slices_created_on, slices.changed_on AS slices_changed_on, slices.id AS slices_id, slices.slice_name AS slices_slice_name, slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type, slices.datasource_name AS slices_datasource_name, slices.viz_type AS slices_viz_type, slices.params AS slices_params, slices.query_context AS slices_query_context, slices.description AS slices_description, slices.cache_timeout AS slices_cache_timeout, slices.perm AS slices_perm, slices.schema_perm AS slices_schema_perm, slices.last_saved_at AS slices_last_saved_at, slices.last_saved_by_fk AS slices_last_saved_by_fk, slices.certified_by AS slices_certified_by, slices.certification_details AS slices_certification_details, slices.is_managed_externally AS slices_is_managed_externally, slices.external_url AS slices_external_url, slices.created_by_fk AS slices_created_by_fk, slices.changed_by_fk AS slices_changed_by_fk
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id

SELECT tables.uuid AS tables_uuid, tables.created_on AS tables_created_on, tables.changed_on AS tables_changed_on, tables.id AS tables_id, tables.description AS tables_description, tables.default_endpoint AS tables_default_endpoint, tables.is_featured AS tables_is_featured, tables.filter_select_enabled AS tables_filter_select_enabled, tables."offset" AS tables_offset, tables.cache_timeout AS tables_cache_timeout, tables.params AS tables_params, tables.perm AS tables_perm, tables.schema_perm AS tables_schema_perm, tables.is_managed_externally AS tables_is_managed_externally, tables.external_url AS tables_external_url, tables.table_name AS tables_table_name, tables.main_dttm_col AS tables_main_dttm_col, tables.database_id AS tables_database_id, tables.fetch_values_predicate AS tables_fetch_values_predicate, tables.schema AS tables_schema, tables.sql AS tables_sql, tables.is_sqllab_view AS tables_is_sqllab_view, tables.template_params AS tables_template_params, tables.extra AS tables_extra, tables.normalize_columns AS tables_normalize_columns, tables.created_by_fk AS tables_created_by_fk, tables.changed_by_fk AS tables_changed_by_fk, anon_1.slices_datasource_id AS anon_1_slices_datasource_id, anon_1.slices_datasource_type AS anon_1_slices_datasource_type
superset_app             | FROM (SELECT DISTINCT slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id) AS anon_1 JOIN tables ON anon_1.slices_datasource_id = tables.id AND anon_1.slices_datasource_type = %(datasource_type_1)s

Always-prog · 2023-08-24T14:18:28Z

Seems safe to remove those outerjoins, yet it's not clear to me what kind of requests are you referring to, will assume db request/queries:

Tested with /api/v1/dashboard/8/charts (using the example dashboard Sales)

With this change, generated queries:

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT slices.uuid AS slices_uuid, slices.created_on AS slices_created_on, slices.changed_on AS slices_changed_on, slices.id AS slices_id, slices.slice_name AS slices_slice_name, slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type, slices.datasource_name AS slices_datasource_name, slices.viz_type AS slices_viz_type, slices.params AS slices_params, slices.query_context AS slices_query_context, slices.description AS slices_description, slices.cache_timeout AS slices_cache_timeout, slices.perm AS slices_perm, slices.schema_perm AS slices_schema_perm, slices.last_saved_at AS slices_last_saved_at, slices.last_saved_by_fk AS slices_last_saved_by_fk, slices.certified_by AS slices_certified_by, slices.certification_details AS slices_certification_details, slices.is_managed_externally AS slices_is_managed_externally, slices.external_url AS slices_external_url, slices.created_by_fk AS slices_created_by_fk, slices.changed_by_fk AS slices_changed_by_fk
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id

SELECT tables.uuid AS tables_uuid, tables.created_on AS tables_created_on, tables.changed_on AS tables_changed_on, tables.id AS tables_id, tables.description AS tables_description, tables.default_endpoint AS tables_default_endpoint, tables.is_featured AS tables_is_featured, tables.filter_select_enabled AS tables_filter_select_enabled, tables."offset" AS tables_offset, tables.cache_timeout AS tables_cache_timeout, tables.params AS tables_params, tables.perm AS tables_perm, tables.schema_perm AS tables_schema_perm, tables.is_managed_externally AS tables_is_managed_externally, tables.external_url AS tables_external_url, tables.table_name AS tables_table_name, tables.main_dttm_col AS tables_main_dttm_col, tables.database_id AS tables_database_id, tables.fetch_values_predicate AS tables_fetch_values_predicate, tables.schema AS tables_schema, tables.sql AS tables_sql, tables.is_sqllab_view AS tables_is_sqllab_view, tables.template_params AS tables_template_params, tables.extra AS tables_extra, tables.normalize_columns AS tables_normalize_columns, tables.created_by_fk AS tables_created_by_fk, tables.changed_by_fk AS tables_changed_by_fk, anon_1.slices_datasource_id AS anon_1_slices_datasource_id, anon_1.slices_datasource_type AS anon_1_slices_datasource_type
superset_app             | FROM (SELECT DISTINCT slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id) AS anon_1 JOIN tables ON anon_1.slices_datasource_id = tables.id AND anon_1.slices_datasource_type = %(datasource_type_1)s

Before this change:

SELECT dashboards.uuid AS dashboards_uuid, dashboards.created_on AS dashboards_created_on, dashboards.changed_on AS dashboards_changed_on, dashboards.id AS dashboards_id, dashboards.dashboard_title AS dashboards_dashboard_title, dashboards.position_json AS dashboards_position_json, dashboards.description AS dashboards_description, dashboards.css AS dashboards_css, dashboards.certified_by AS dashboards_certified_by, dashboards.certification_details AS dashboards_certification_details, dashboards.json_metadata AS dashboards_json_metadata, dashboards.slug AS dashboards_slug, dashboards.published AS dashboards_published, dashboards.is_managed_externally AS dashboards_is_managed_externally, dashboards.external_url AS dashboards_external_url, dashboards.created_by_fk AS dashboards_created_by_fk, dashboards.changed_by_fk AS dashboards_changed_by_fk
superset_app             | FROM dashboards LEFT OUTER JOIN (dashboard_slices AS dashboard_slices_1 JOIN slices ON slices.id = dashboard_slices_1.slice_id) ON dashboards.id = dashboard_slices_1.dashboard_id LEFT OUTER JOIN tables ON slices.datasource_id = tables.id AND slices.datasource_type = %(datasource_type_1)s LEFT OUTER JOIN (dashboard_user AS dashboard_user_1 JOIN ab_user ON ab_user.id = dashboard_user_1.user_id) ON dashboards.id = dashboard_user_1.dashboard_id LEFT OUTER JOIN (dashboard_roles AS dashboard_roles_1 JOIN ab_role ON ab_role.id = dashboard_roles_1.role_id) ON dashboards.id = dashboard_roles_1.dashboard_id
superset_app             | WHERE dashboards.id = %(id_1)s

SELECT slices.uuid AS slices_uuid, slices.created_on AS slices_created_on, slices.changed_on AS slices_changed_on, slices.id AS slices_id, slices.slice_name AS slices_slice_name, slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type, slices.datasource_name AS slices_datasource_name, slices.viz_type AS slices_viz_type, slices.params AS slices_params, slices.query_context AS slices_query_context, slices.description AS slices_description, slices.cache_timeout AS slices_cache_timeout, slices.perm AS slices_perm, slices.schema_perm AS slices_schema_perm, slices.last_saved_at AS slices_last_saved_at, slices.last_saved_by_fk AS slices_last_saved_by_fk, slices.certified_by AS slices_certified_by, slices.certification_details AS slices_certification_details, slices.is_managed_externally AS slices_is_managed_externally, slices.external_url AS slices_external_url, slices.created_by_fk AS slices_created_by_fk, slices.changed_by_fk AS slices_changed_by_fk
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id

SELECT tables.uuid AS tables_uuid, tables.created_on AS tables_created_on, tables.changed_on AS tables_changed_on, tables.id AS tables_id, tables.description AS tables_description, tables.default_endpoint AS tables_default_endpoint, tables.is_featured AS tables_is_featured, tables.filter_select_enabled AS tables_filter_select_enabled, tables."offset" AS tables_offset, tables.cache_timeout AS tables_cache_timeout, tables.params AS tables_params, tables.perm AS tables_perm, tables.schema_perm AS tables_schema_perm, tables.is_managed_externally AS tables_is_managed_externally, tables.external_url AS tables_external_url, tables.table_name AS tables_table_name, tables.main_dttm_col AS tables_main_dttm_col, tables.database_id AS tables_database_id, tables.fetch_values_predicate AS tables_fetch_values_predicate, tables.schema AS tables_schema, tables.sql AS tables_sql, tables.is_sqllab_view AS tables_is_sqllab_view, tables.template_params AS tables_template_params, tables.extra AS tables_extra, tables.normalize_columns AS tables_normalize_columns, tables.created_by_fk AS tables_created_by_fk, tables.changed_by_fk AS tables_changed_by_fk, anon_1.slices_datasource_id AS anon_1_slices_datasource_id, anon_1.slices_datasource_type AS anon_1_slices_datasource_type
superset_app             | FROM (SELECT DISTINCT slices.datasource_id AS slices_datasource_id, slices.datasource_type AS slices_datasource_type
superset_app             | FROM slices, dashboard_slices
superset_app             | WHERE %(param_1)s = dashboard_slices.dashboard_id AND slices.id = dashboard_slices.slice_id) AS anon_1 JOIN tables ON anon_1.slices_datasource_id = tables.id AND anon_1.slices_datasource_type = %(datasource_type_1)s

Hello! Thanks for the reply!
I mean, when we join slices in the query, the number of rows returned corresponds to the number of slices in the dashboard. Each row contains the JSON of the dashboard. As a result, if the dashboard JSON is 1MB in size and there are 100 slices, it will return 100MB, not 1MB.

… it has (#24709) (cherry picked from commit 75a7431)

* fix(sqllab): reinstate "Force trino client async execution" (apache#25680) * fix: remove unnecessary redirect (apache#25679) (cherry picked from commit da42bf2) * fix(chore): dashboard requests to database equal the number of slices it has (apache#24709) (cherry picked from commit 75a7431) * fix: bump to FAB 4.3.9 remove CSP exception (apache#25712) (cherry picked from commit 8fb0c8d) * fix(horizontal filter label): show full tooltip with ellipsis (apache#25732) (cherry picked from commit e4173d9) * fix: Revert "fix(Charts): Set max row limit + removed the option to use an empty row limit value" (apache#25753) (cherry picked from commit e2fe967) * fix: dataset update uniqueness (apache#25756) (cherry picked from commit c7f8d11) * fix(sqllab): slow pop datasource query (apache#25741) (cherry picked from commit 2a2bc82) * fix: allow for backward compatible errors (apache#25640) * fix: DB-specific quoting in Jinja macro (apache#25779) (cherry picked from commit 5659c87) * fix: Revert "fix: Apply normalization to all dttm columns (apache#25147)" (apache#25801) * fix: Resolve issue apache#24195 (apache#25804) (cherry picked from commit 8737a8a) * fix(SQL field in edit dataset modal): display full sql query (apache#25768) (cherry picked from commit 1eba712) * fix(sqllab): infinite fetching status after results are landed (apache#25814) (cherry picked from commit 3f28eeb) * fix: Fires onChange when clearing all values of single select (apache#25853) (cherry picked from commit 8061d5c) * fix: the temporal x-axis results in a none time_range. (apache#25429) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> (cherry picked from commit ae619b1) * fix(table chart): Show Cell Bars correctly apache#25625 (apache#25707) (cherry picked from commit 916f7bc) * fix: remove `update_charts_owners` (apache#25843) * fix(charts): Time grain is None when dataset uses Jinja (apache#25842) (cherry picked from commit 7536dd1) * fix: Saving Mixed Chart with dashboard filter applied breaks adhoc_filter_b (apache#25877) (cherry picked from commit 268c1dc) * fix: database version field (apache#25898) (cherry picked from commit 06ffcd2) * fix: trino cursor (apache#25897) (cherry picked from commit cdb18e0) * chore: Updates CHANGELOG.md for 3.0.2 * fix(trino): allow impersonate_user flag to be imported (apache#25872) Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit 458be8c) * fix(table): Double percenting ad-hoc percentage metrics (apache#25857) (cherry picked from commit 784a478) * fix(sqllab): invalid sanitization on comparison symbol (apache#25903) (cherry picked from commit 581d3c7) * fix: update flask-caching to avoid breaking redis cache, solves apache#25339 (apache#25947) Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * fix: always denorm column value before querying values (apache#25919) * chore(colors): Updating Airbnb brand colors (apache#23619) (cherry picked from commit 6d8424c) * fix: naming denomalized to denormalized in helpers.py (apache#25973) (cherry picked from commit 5def416) * fix(helm): Restart all related deployments when bootstrap script changed (apache#25703) * fix(rls): Update text from tables to datasets in RLS modal (apache#25997) (cherry picked from commit 210f1f8) * fix: Make Select component fire onChange listener when a selection is pasted in (apache#25993) (cherry picked from commit 5fccf67) * fix(explore): redandant force param (apache#25985) (cherry picked from commit e7a1876) * chore: Optimize fetching samples logic (apache#25995) (cherry picked from commit 326ac4a) * fix(native filters): rendering performance improvement by reduce overrendering (apache#25901) (cherry picked from commit e1d73d5) * fix: update FAB to 4.3.10, Azure user info fix (apache#26037) (cherry picked from commit 628cd34) * chore: Updates CHANGELOG.md for 3.0.2 (rc2) --------- Co-authored-by: Rob Moore <giftig@users.noreply.github.com> Co-authored-by: Igor Khrol <igor.khrol@automattic.com> Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Ross Mabbett <92495987+rtexelm@users.noreply.github.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: mapledan <mapledan829@gmail.com> Co-authored-by: Arko <90512504+SA-Ark@users.noreply.github.com> Co-authored-by: Antonio Rivero <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: FGrobelny <150029280+FGrobelny@users.noreply.github.com> Co-authored-by: Giacomo Barone <46573388+ggbaro@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: josedev-union <70741025+josedev-union@users.noreply.github.com> Co-authored-by: yousoph <sophieyou12@gmail.com> Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>

… it has (apache#24709)

fix(chore): dashboard requests to database equal the number of slices…

5e567ad

… it has

pull-request-size bot added the size/S label Jul 16, 2023

Always-prog added 3 commits July 16, 2023 11:55

ooops

ba140a7

fix(chore): simplify getting dashboard in get_by_id_or_slug

3e7b9bf

removed unused

d1f8af9

Always-prog marked this pull request as draft July 16, 2023 10:29

fix(chore): return back base filter in dashboard get_by_id_or_slug & …

7068e10

…removed joining slices

pull-request-size bot added size/XS and removed size/S labels Jul 16, 2023

Always-prog marked this pull request as ready for review July 16, 2023 13:18

pylint

219310e

john-bodley reviewed Jul 18, 2023

View reviewed changes

john-bodley requested a review from dpgaspar July 18, 2023 16:55

Always-prog requested a review from john-bodley August 17, 2023 05:55

rusackas requested review from michael-s-molina, justinpark and eschutho August 23, 2023 16:26

rusackas added the v2.1 label Aug 23, 2023

dpgaspar reviewed Aug 24, 2023

View reviewed changes

Always-prog requested a review from dpgaspar August 25, 2023 06:48

dpgaspar self-assigned this Oct 20, 2023

dpgaspar added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v2.1 labels Oct 20, 2023

dpgaspar approved these changes Oct 20, 2023

View reviewed changes

dpgaspar merged commit 75a7431 into apache:master Oct 20, 2023
29 checks passed

michael-s-molina pushed a commit that referenced this pull request Oct 31, 2023

fix(chore): dashboard requests to database equal the number of slices…

8483ab6

… it has (#24709) (cherry picked from commit 75a7431)

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix(chore): dashboard requests to database equal the number of slices…

4c65406

… it has (apache#24709)

mistercrunch added 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

fix(chore): dashboard requests to database equal the number of slices…

4115a9c

… it has (apache#24709)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(chore): dashboard requests to database equal the number of slices it has #24709

fix(chore): dashboard requests to database equal the number of slices it has #24709

Always-prog commented Jul 16, 2023 •

edited

codecov bot commented Jul 16, 2023 •

edited

Always-prog commented Jul 16, 2023

john-bodley Jul 18, 2023

Always-prog commented Aug 3, 2023 •

edited

Always-prog commented Aug 16, 2023 •

edited

dpgaspar left a comment •

edited

Always-prog commented Aug 24, 2023 •

edited

fix(chore): dashboard requests to database equal the number of slices it has #24709

fix(chore): dashboard requests to database equal the number of slices it has #24709

Conversation

Always-prog commented Jul 16, 2023 • edited

SUMMARY

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 16, 2023 • edited

Codecov Report

Always-prog commented Jul 16, 2023

john-bodley Jul 18, 2023

Choose a reason for hiding this comment

Always-prog commented Aug 3, 2023 • edited

Always-prog commented Aug 16, 2023 • edited

dpgaspar left a comment • edited

Choose a reason for hiding this comment

Always-prog commented Aug 24, 2023 • edited

Always-prog commented Jul 16, 2023 •

edited

codecov bot commented Jul 16, 2023 •

edited

Always-prog commented Aug 3, 2023 •

edited

Always-prog commented Aug 16, 2023 •

edited

dpgaspar left a comment •

edited

Always-prog commented Aug 24, 2023 •

edited