fix: remove update_charts_owners

[betodealmeida]

SUMMARY

Currently, when a user adds a chart they don't own to a dashboard they own, they are added as owners of the chart. This behavior doesn't make sense, and allows for malicious behavior — users can modify or delete any chart this way.

This PR removes that logic.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Create a chart as the admin user. Now login as the gamma user, and add that chart to a new dashboard. The gamma user should be able to add the chart, and they should not be added as an owner of the chart.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

@betodealmeida this logic was added in #9484 and thus maybe there's merit in connecting with @dpgaspar with regards to what the correct logic should be.

Per the following screenshot it seems like one can add charts, so is the correct logic that if you add a chart you don't own then you don't become an owner of the underlying chart?

[rusackas]

Related PR: #21720

[betodealmeida]

@betodealmeida this logic was added in #9484 and thus maybe there's merit in connecting with @dpgaspar with regards to what the correct logic should be.

He said "don't recall but it seems it was a fix for a regression, I think superset as always "worked" like that, maybe because when selecting charts for a dashboard you could only choose charts you owned".

Per the following screenshot it seems like one can add charts, so is the correct logic that if you add a chart you don't own then you don't become an owner of the underlying chart?

Right, I think the old behavior doesn't apply anymore; users can now add charts that they don't own. I can't imagine a valid reason for allowing users to add themselves as owners of arbitrary charts.