Skip to content

Audit Hold Paths

Evan Rusackas edited this page Nov 19, 2026 · 2 revisions

This page is read by CI. When a pull request changes a file matching one of the paths below, the wiki labeler workflow adds the hold:audit-* label for that section. Any hold label blocks merging until someone removes it.

Removing the label is how a reviewer says "I checked this specific risk". It is not a formality to clear once the rest of the review looks fine. The label comes back if the PR is pushed to again, and it drops off by itself if the PR stops touching those paths.

Edits here take effect within a few minutes, with no pull request needed. The page history is the audit trail. See Labeling Automation for the other pages that drive labels.

How to edit this page

  • Each ## heading below the line is a label name. It must start with hold:audit-; CI ignores any other heading.
  • A list item is a path pattern, relative to the repository root. ** matches any number of folders, * matches within one folder. Wrap patterns in backticks so the wiki does not turn the asterisks into bold text.
  • The list under Reviewers: names the people who know the area. CI requests a review from each of them when a PR gets the label, once the PR is out of draft. It skips the PR's author and anyone already asked or already reviewing. Only people with access to the repository can be asked; CI skips anyone else with a warning.
  • Everything else is ignored by CI, so the notes on what to check can be as long as they need to be. This page is also what AGENTS.md in the repository points to for the meaning of each label, so keep those notes complete.
  • Every edit is checked by CI. If the page stops reading cleanly, the check fails and GitHub emails you what to fix. A broken page here blocks merging for every PR until it is fixed, because CI refuses to guess at hold rules.
  • Removing a path, or a whole section, lifts that hold from open PRs the next time they are pushed to. Treat those edits with the same care as approving the PRs themselves.

hold:audit-gha

GitHub Actions supply-chain risk. Check that no workflow gains broader permissions: than it needs, third-party actions are pinned to a full commit SHA, no untrusted PR input (title, body, branch name, fork code) reaches a run: step or a template expression, pull_request_target / workflow_run jobs never run fork code with a writable token, and zizmor passes or any ignore is justified inline.

Paths:

  • .github/**

Reviewers:

  • @villebro
  • @geido
  • @eschutho
  • @rusackas
  • @betodealmeida
  • @nytai
  • @mistercrunch
  • @kgabryje
  • @sha174n
  • @dpgaspar
  • @sadpandajoe
  • @hainenber
  • @msyavuz
  • @aminghadersohi

hold:audit-scripts

These scripts run directly in CI with the job's full permissions, so a change here is a change to the CI environment. Check for new fetch-and-run of unpinned remote content, secrets or tokens being echoed or logged, and shell injection through unsanitized input.

Paths:

  • scripts/**

Reviewers:

  • @villebro
  • @geido
  • @eschutho
  • @rusackas
  • @betodealmeida
  • @nytai
  • @mistercrunch
  • @kgabryje
  • @dpgaspar
  • @sha174n
  • @sadpandajoe
  • @hainenber
  • @msyavuz
  • @aminghadersohi

hold:audit-asf-yaml

ASF Infra reads this file to set the repository's branch protection and notification routing. Check that required reviews and required status checks are not being weakened, and that any notification target is a real, intended destination.

Paths:

  • .asf.yaml

Reviewers:

  • @villebro
  • @geido
  • @eschutho
  • @rusackas
  • @betodealmeida
  • @nytai
  • @mistercrunch
  • @kgabryje
  • @dpgaspar
  • @sha174n
  • @sadpandajoe
  • @Antonio-RiveroMartnez
  • @msyavuz
  • @aminghadersohi

hold:audit-maps

The GeoJSON files are generated output, so a hand edit is overwritten the next time the maps are regenerated. Check that edits went through the generator (the scripts in superset-frontend/plugins/plugin-chart-country-map/scripts/). For changes to boundaries, names or disputed territories, confirm there is a cited source: these are politically sensitive.

Paths:

  • **/*.geojson
  • **/*.ipynb
  • superset-frontend/plugins/plugin-chart-country-map/**

Reviewers:

  • @villebro
  • @rusackas
  • @sadpandajoe

hold:audit-extensions

Two risks share these paths. superset/extensions/__init__.py wires security-relevant Flask extensions (CSRF, Talisman/CSP, the security manager), so check nothing loosens a default. The rest is the public, versioned extension API that third-party authors build against, so check that a contract change is backward-compatible or an intentional, documented break.

Paths:

  • docs/developer_docs/extensions/**
  • superset-extensions-cli/**
  • superset/extensions/**
  • superset-frontend/src/extensions/**

Reviewers:

  • @michael-s-molina
  • @villebro
  • @rusackas
  • @sadpandajoe
  • @geido
  • @msyavuz

hold:audit-config

Superset's shipped default configuration. Anything a deployment does not override inherits these values. Check that no feature flag flips on early and no security-relevant default (auth, CORS, CSP, session and cookie settings) loosens.

Paths:

  • superset/config.py

Reviewers:

  • @michael-s-molina
  • @villebro
  • @rusackas
  • @sadpandajoe
  • @geido
  • @msyavuz
  • @aminghadersohi

Clone this wiki locally