Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent profile name restrictions #6018

Merged

Conversation

ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

This PR ensures that spaces in Profile names are consistently forbidden throughout the API.

Which Traffic Control components are affected by this PR?

  • Traffic Ops Client (Go) (Tests only)
  • Traffic Ops
  • Traffic Portal

What is the best way to verify this PR?

Make sure the tests all pass.

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 4.x
  • 5.x

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one labels Jul 13, 2021
@ocket8888 ocket8888 force-pushed the consistent-profile-name-restrictions branch 3 times, most recently from b1fe859 to 802885e Compare July 15, 2021 14:26
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocket8888 ocket8888 force-pushed the consistent-profile-name-restrictions branch from 802885e to d3564b8 Compare July 20, 2021 19:59
@ocket8888 ocket8888 force-pushed the consistent-profile-name-restrictions branch 2 times, most recently from 3cc0fb1 to 4cebe0b Compare August 4, 2021 15:09
CHANGELOG.md Outdated Show resolved Hide resolved
@ocket8888 ocket8888 force-pushed the consistent-profile-name-restrictions branch from 4cebe0b to 6d6fe43 Compare August 11, 2021 18:22
@zrhoffman zrhoffman merged commit 14d88e5 into apache:master Aug 11, 2021
@ocket8888 ocket8888 deleted the consistent-profile-name-restrictions branch August 11, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Profile Name restrictions
3 participants