Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send fallbackToClosest as a boolean instead of a string #6562

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

davidc0le
Copy link
Contributor

Closes: #6539

Adjusting the Ansible dataset loader cacheGroup jinja template to send fallbackToClosest ( if provided ) as a boolean instead of a string.


Which Traffic Control components are affected by this PR?

  • Automation (Ansible)

What is the best way to verify this PR?

An example to trigger this is listed with the issue #6539

If this is a bugfix, which Traffic Control versions contained the bug?

5.1.x
6.x

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@jhg03a
Copy link
Contributor

jhg03a commented Feb 14, 2022

LGTM if it passes checks

@jhg03a
Copy link
Contributor

jhg03a commented Feb 14, 2022

Mind adding a changelog entry @davidc0le ?

@ocket8888 ocket8888 added ansible Related to the Ansible roles bug something isn't working as intended labels Feb 14, 2022
@jhg03a jhg03a merged commit ab5bfbd into apache:master Feb 15, 2022
@github-actions github-actions bot mentioned this pull request Mar 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Related to the Ansible roles bug something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible dataset_loader cachegroup template renders fallbackToClosest to be a string instead of a bool
3 participants