Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing registration changelog to include username #7511

Merged
merged 5 commits into from
May 12, 2023

Conversation

srijeet0406
Copy link
Contributor

This PR is not related to any issue. It fixes the changelog entry to include the username instead of email twice, when a registration is sent to a user.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Send a user registration email on TO/ TP and make sure the corresponding changelog shows the correct username for the user, instead of email.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #7511 (ec56d17) into master (1c11f7f) will increase coverage by 2.57%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7511      +/-   ##
============================================
+ Coverage     27.60%   30.17%   +2.57%     
  Complexity       98       98              
============================================
  Files           686      789     +103     
  Lines         77933    82299    +4366     
  Branches         90      815     +725     
============================================
+ Hits          21513    24834    +3321     
- Misses        54400    55386     +986     
- Partials       2020     2079      +59     
Flag Coverage Δ
golib_unit 48.58% <ø> (+0.01%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.32% <ø> (ø)
traffic_monitor_unit 21.28% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 23.14% <0.00%> (-0.01%) ⬇️
traffic_portal_v2 76.08% <ø> (?)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 27.23% <0.00%> (+2.99%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
traffic_ops/traffic_ops_golang/login/register.go 0.00% <0.00%> (ø)

... and 105 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one labels May 12, 2023
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. I tested it locally and now the change log messages show username as registration_random_alphanumeric_characters instead of email or empty

traffic_ops/traffic_ops_golang/login/register.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/login/register.go Outdated Show resolved Hide resolved
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All works correctly. Failing TPv1 and TPv2 tests have nothing to do with this PR.

@rimashah25 rimashah25 merged commit b0d00b1 into apache:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants