-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing registration changelog to include username #7511
Changing registration changelog to include username #7511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7511 +/- ##
============================================
+ Coverage 27.60% 30.17% +2.57%
Complexity 98 98
============================================
Files 686 789 +103
Lines 77933 82299 +4366
Branches 90 815 +725
============================================
+ Hits 21513 24834 +3321
- Misses 54400 55386 +986
- Partials 2020 2079 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. I tested it locally and now the change log messages show username as registration_random_alphanumeric_characters
instead of email or empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All works correctly. Failing TPv1 and TPv2 tests have nothing to do with this PR.
This PR is not related to any issue. It fixes the changelog entry to include the username instead of email twice, when a registration is sent to a user.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Send a user registration email on TO/ TP and make sure the corresponding changelog shows the correct username for the user, instead of email.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist