Skip to content

Conversation

dolphingarlic
Copy link
Contributor

This is for that one GCI task

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 235

  • 7 of 8 (87.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.08%) to 80.441%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apertium/init.py 2 3 66.67%
Totals Coverage Status
Change from base Build 221: 1.08%
Covered Lines: 584
Relevant Lines: 726

💛 - Coveralls

@dolphingarlic
Copy link
Contributor Author

Should I be worrying about these Travis CI issues?

@sushain97
Copy link
Member

I don't merge PRs that fail the build if it was passing before unless it's not your fault :)

@dolphingarlic
Copy link
Contributor Author

Here's what I get when I run "mypy -p apertium --ignore-missing-imports --txt-report coverage" on the files with the docstrings:

Mypy Type Check Coverage Summary

Script: index

+----------------------+-------------------+---------+
| Module | Imprecision | Lines |
+----------------------+-------------------+---------+
| apertium | 0.00% imprecise | 46 LOC |
| apertium.analysis | 8.86% imprecise | 79 LOC |
| apertium.generation | 0.00% imprecise | 65 LOC |
| apertium.mode_search | 0.00% imprecise | 88 LOC |
| apertium.translation | 5.85% imprecise | 188 LOC |
| apertium.utils | 1.49% imprecise | 67 LOC |
+----------------------+-------------------+---------+
| Total | 3.56% imprecise | 533 LOC |
+----------------------+-------------------+---------+

Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a random swap file?

@sushain97 sushain97 merged commit 4c87dc8 into apertium:master Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants